-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: drivers: gpio: gpio_basic_api: correct dts binding #29689
Comments
While it's true that the vast majority of I don't object to making this change if we agree and document that's a standard we should follow, and add checks to the tooling to warn when people violate it. @sjg20 @mbolivar @galak |
BTW: I believe the reason I went with |
While it seems general convention to use |
Certainly this is a pretty strong convention. The DT spec examples all use hyphen and the the /aliases node requires it, but oddly it has capital letters for the alias labels. This convention is a bit confusing in Zephyr because hyphen gets converted to underscore to become a valid C identifier The underscore is reserved for phandle names. |
@cfriedt I'm happy to have a crack at a DT spec update if you don't want to do it. |
I think it's unrelated to the other PR for the most part, so please go ahead. |
Applied here: |
Is your enhancement proposal related to a problem? Please describe.
As @sjg20 pointed out in #26484, compatible strings should use '-' instead of '_'.
Describe the solution you'd like
The existing "test,gpio_basic_api" binding should be changed to "test,gpio-basic-api". All of the boards / relevant files in
tests/drivers/gpio/gpio_basic_api
should be corrected to reflect that change.Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: