Add more restrictions on compatible strings #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherring
reviewed
Mar 23, 2021
| @@ -484,6 +484,9 @@ Description: | |||
| (such as a stock ticker symbol), and ``model`` specifies the model | |||
| number. | |||
|
|
|||
| The compatible string should consist only of lowercase letters, digits, | |||
| dashes and at most a single comma. Underscores should not be used. | |||
There was a problem hiding this comment.
I would say something like "a single comma is typically only used following a vendor prefix."
There was a problem hiding this comment.
OK I updated it, but please feel free to edit it to be clearer.
Mostly we use lower case and we try to avoid underscores. Add a note about this. I believe this is just writing down the existing conventions. I have not gone as far as using a character table (as with aliases) or specifying a maximum length. Signed-off-by: Simon Glass <sjg@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly we use lower case and we try to avoid underscores. Add a note
about this.
I believe this is just writing down the existing conventions. I have not
gone as far as using a character table (as with aliases) or specifying a
maximum length.
(this was reference at zephyrproject-rtos/zephyr#29689 (comment) )
Signed-off-by: Simon Glass sjg@chromium.org