Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shield: cmake: Shield conf is not loaded during build #32269

Closed
Zzzwierzak opened this issue Feb 12, 2021 · 5 comments · Fixed by #32318
Closed

shield: cmake: Shield conf is not loaded during build #32269

Zzzwierzak opened this issue Feb 12, 2021 · 5 comments · Fixed by #32318
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Zzzwierzak
Copy link
Contributor

Describe the bug
Shield conf is not loaded during build

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=board_xyz -DSHIELD=abc
  3. make
  4. See error - abc.proj is not taken to build.

Expected behavior
abc.conf is used during cmake

Impact
Missing configuration(in autoconf.h) for shield.

Workaround/Fix
zephyr/cmake/app/boilerplate.cmake

Change line 350 from :
if(EXISTS ${shield_dir}/${s_dir}/${s}.conf)
To:
if(EXISTS ${SHIELD_DIR_${s}}/${s}.conf)

@Zzzwierzak Zzzwierzak added the bug The issue is a bug, or the PR is fixing a bug label Feb 12, 2021
@erwango
Copy link
Member

erwango commented Feb 12, 2021

@tejlmand

EDIT: I'm letting you set the criticity.

@carlescufi
Copy link
Member

@jfischer-no and @erwango can you confirm?

@jfischer-no
Copy link
Collaborator

@jfischer-no and @erwango can you confirm?

No. Just tried it out, the shields we have in the tree work fine.
This issue description is weird. It is been a long time since we switched from *.conf to similar Kconfig structure as in boards.

@tejlmand
Copy link
Collaborator

@Zzzwierzak thanks for reporting, fixed here: #32318

@Zzzwierzak
Copy link
Contributor Author

@tejlmand Thank you.

tejlmand added a commit to tejlmand/zephyr that referenced this issue Feb 15, 2021
Fixes: zephyrproject-rtos#32269

This commit is a followup to zephyrproject-rtos#31877 where the `${shield_dir}/${s_dir}`
was adjusted to `${SHIELD_DIR_${s}}` to ensure only including shields
and not boards in list of known shields.

An `if(EXISTS ${shield_dir}/${s_dir}...)` was missed in this process
which causes zephyrproject-rtos#32269. This is corrected in this commit.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
MaureenHelm pushed a commit that referenced this issue Mar 1, 2021
Fixes: #32269

This commit is a followup to #31877 where the `${shield_dir}/${s_dir}`
was adjusted to `${SHIELD_DIR_${s}}` to ensure only including shields
and not boards in list of known shields.

An `if(EXISTS ${shield_dir}/${s_dir}...)` was missed in this process
which causes #32269. This is corrected in this commit.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants