-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shield: cmake: Shield conf is not loaded during build #32269
Labels
Comments
EDIT: I'm letting you set the criticity. |
@jfischer-no and @erwango can you confirm? |
No. Just tried it out, the shields we have in the tree work fine. |
@Zzzwierzak thanks for reporting, fixed here: #32318 |
@tejlmand Thank you. |
tejlmand
added a commit
to tejlmand/zephyr
that referenced
this issue
Feb 15, 2021
Fixes: zephyrproject-rtos#32269 This commit is a followup to zephyrproject-rtos#31877 where the `${shield_dir}/${s_dir}` was adjusted to `${SHIELD_DIR_${s}}` to ensure only including shields and not boards in list of known shields. An `if(EXISTS ${shield_dir}/${s_dir}...)` was missed in this process which causes zephyrproject-rtos#32269. This is corrected in this commit. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
MaureenHelm
pushed a commit
that referenced
this issue
Mar 1, 2021
Fixes: #32269 This commit is a followup to #31877 where the `${shield_dir}/${s_dir}` was adjusted to `${SHIELD_DIR_${s}}` to ensure only including shields and not boards in list of known shields. An `if(EXISTS ${shield_dir}/${s_dir}...)` was missed in this process which causes #32269. This is corrected in this commit. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
Shield conf is not loaded during build
To Reproduce
Steps to reproduce the behavior:
Expected behavior
abc.conf is used during cmake
Impact
Missing configuration(in autoconf.h) for shield.
Workaround/Fix
zephyr/cmake/app/boilerplate.cmake
Change line 350 from :
if(EXISTS ${shield_dir}/${s_dir}/${s}.conf)
To:
if(EXISTS ${SHIELD_DIR_${s}}/${s}.conf)
The text was updated successfully, but these errors were encountered: