[Coverity CID :219545] Side effect in assertion in subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/controller/ll_sw/ull_adv_aux.c#L1079

Category: Incorrect expression
Function: mfy_aux_offset_get
Component: Bluetooth
CID: 219545

Details:

zephyr/subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

Line 1079 in bd97359

LL_ASSERT(ret_cb == TICKER_STATUS_SUCCESS);

1073                 while (ret_cb == TICKER_STATUS_BUSY) {
1074                     ticker_job_sched(TICKER_INSTANCE_ID_CTLR,
1075                              TICKER_USER_ID_ULL_LOW);
1076                 }
1077             }
1078    
>>>     CID 219545:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "ret_cb" of LL_ASSERT() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
1079             LL_ASSERT(ret_cb == TICKER_STATUS_SUCCESS);
1080    
1081             LL_ASSERT((ticks_current == ticks_previous) || retry--);
1082    
1083             LL_ASSERT(id != TICKER_NULL);
1084         } while (id != ticker_id);

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.