[Coverity CID :219529] Unchecked return value in subsys/bluetooth/controller/ll_sw/ull_filter.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/controller/ll_sw/ull_filter.c#L1121

Category: Error handling issues
Function: target_resolve
Component: Bluetooth
CID: 219529

Details:

zephyr/subsys/bluetooth/controller/ll_sw/ull_filter.c

Line 1121 in bd97359

mayfly_enqueue(TICKER_USER_ID_THREAD,

1115          * Pass param FILTER_IDX_NONE if RPA can not be resolved,
1116          * or index in cache if it can be resolved
1117          */
1118         if (twork->cb) {
1119             mfy.fp = twork->cb;
1120             mfy.param = (void *) ((unsigned int) j);
>>>     CID 219529:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "mayfly_enqueue" without checking return value (as is done elsewhere 15 out of 17 times).
1121             mayfly_enqueue(TICKER_USER_ID_THREAD,
1122                        TICKER_USER_ID_LLL, 1, &mfy);
1123         }
1124     }
1125    
1126     static uint8_t prpa_cache_try_resolve(bt_addr_t *rpa)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[gudnimg]

I couldn’t find any documentation for the mayfly code. https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/controller/util/mayfly.c there are no doxygen comments in mayfly.h

Seems to return 0 or 1 but it is unclear to me what those values mean.

I’m curious what a “mayfly” is 🤔

[cvinayak]

mayfly is an internal framework in the Bluetooth Low Energy Controller implementation to schedule a function's execution in a different execution context. It can be seen as a software interrupt mechanism.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.