Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :219522] Unchecked return value in tests/subsys/dfu/mcuboot/src/main.c #32924

Closed
zephyrbot opened this issue Mar 5, 2021 · 0 comments · Fixed by #33151
Closed

[Coverity CID :219522] Unchecked return value in tests/subsys/dfu/mcuboot/src/main.c #32924

zephyrbot opened this issue Mar 5, 2021 · 0 comments · Fixed by #33151
Assignees
@de-nordic
Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/tests/subsys/dfu/mcuboot/src/main.c

Category: Error handling issues
Function: test_request_upgrade
Component: Tests
CID: 219522

Details:

zephyr/tests/subsys/dfu/mcuboot/src/main.c

Line 80 in bd97359

boot_erase_img_bank(FLASH_AREA_ID(image_1));

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
@nashif nashif removed their assignment Mar 5, 2021
@de-nordic de-nordic added the area: Tests Issues related to a particular existing or missing test label Mar 8, 2021
@de-nordic de-nordic self-assigned this Mar 8, 2021
de-nordic added a commit to de-nordic/zephyr that referenced this issue Mar 8, 2021
@de-nordic
tests/subsys/dfu/mcuboot: Fix coverity issue on not checked return val
270705e 
The commit fixes coverity issue where return status bank erase operation
has not been checked prior to proceeding with tests.

Fixes: zephyrproject-rtos#32924, Coverity-CID: 219522

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@de-nordic de-nordic mentioned this issue Mar 8, 2021
Merged
nashif pushed a commit that referenced this issue Mar 9, 2021
@de-nordic @nashif
tests/subsys/dfu/mcuboot: Fix coverity issue on not checked return val
df11f2b 
The commit fixes coverity issue where return status bank erase operation
has not been checked prior to proceeding with tests.

Fixes: #32924, Coverity-CID: 219522

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-nordic de-nordic

Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/subsys/dfu/mcuboot: Fix coverity issue on not checked return val de-nordic/zephyr
3 participants
@nashif @zephyrbot @de-nordic