Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219651] Logically dead code in subsys/bluetooth/mesh/net.c #33036

Closed
zephyrbot opened this issue Mar 7, 2021 · 0 comments
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/mesh/net.c#L155

Category: Control flow issues
Function: store_seq
Component: Bluetooth
CID: 219651

Details:

149     }
150    
151     static void store_seq(void)
152     {
153         if (CONFIG_BT_MESH_SEQ_STORE_RATE &&
154             (bt_mesh.seq % CONFIG_BT_MESH_SEQ_STORE_RATE)) {
>>>     CID 219651:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return;".
155             return;
156         }
157    
158         bt_mesh_settings_store_schedule(BT_MESH_SETTINGS_SEQ_PENDING);
159     }
160    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 7, 2021
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Mar 8, 2021
If CONFIG_BT_MESH_SEQ_STORE_RATE is 1, the check in store_seq can be
reduced to a simple if (false), and the modulo code does not need to be
included in the build.

Fixes zephyrproject-rtos#33036.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@nashif nashif closed this as completed in aef354c Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants