Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :219600] Unchecked return value in drivers/watchdog/wdt_wwdg_stm32.c #33067

Closed
zephyrbot opened this issue Mar 7, 2021 · 0 comments
Closed

[Coverity CID :219600] Unchecked return value in drivers/watchdog/wdt_wwdg_stm32.c #33067

zephyrbot opened this issue Mar 7, 2021 · 0 comments
Assignees
@erwango @ABOSTM @FRASTM
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/drivers/watchdog/wdt_wwdg_stm32.c

Category: Error handling issues
Function: wwdg_stm32_init
Component: Drivers
CID: 219600

Details:

zephyr/drivers/watchdog/wdt_wwdg_stm32.c

Line 254 in bd97359

clock_control_on(clk, (clock_control_subsys_t *) &cfg->pclken);

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 7, 2021
@erwango erwango mentioned this issue Mar 8, 2021
Merged
@FRASTM FRASTM added the platform: STM32 ST Micro STM32 label Mar 8, 2021
erwango added a commit to erwango/zephyr that referenced this issue Mar 8, 2021
@erwango
drivers/watchdog: wwdg_stm32: Check return value of clock_control_on
a6cffea 
In function wwdg_stm32_init, return value of clock_control_on
was not checked.
This is reported as an issue by coverity (CID 219600).
Fix this.

Fixes zephyrproject-rtos#33067

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@nashif nashif closed this as completed in 7dc6b03 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

@ABOSTM ABOSTM

@FRASTM FRASTM

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erwango @zephyrbot @ABOSTM @FRASTM