Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 235930] Unused value in kernel/mmu.c #35160

Closed
zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35173
Closed

[Coverity CID: 235930] Unused value in kernel/mmu.c #35160

zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35173
Assignees
@dcpleung
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone
v2.6.0

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/0622bde3bf22926544c1aaef4c01dfa23d79f26e/kernel/mmu.c

Category: Code maintainability issues
Function: virt_region_init
Component: Kernel
CID: 235930

Details:

zephyr/kernel/mmu.c

Line 213 in 0622bde

offset = virt_to_bitmap_offset(Z_VIRT_REGION_END_ADDR,

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 11, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
dcpleung added a commit to dcpleung/zephyr that referenced this issue May 11, 2021
@dcpleung
kernel: mmu: remove un-needed call to virt_to_bitmap_offset
081a6aa 
When marking the reserved region at the end of virtual address
space, call virt_to_bitmap_offset() is not needed as we already
know the offset. So remove it.

Coverity-CID: 235930
Fixes zephyrproject-rtos#35160

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung dcpleung mentioned this issue May 11, 2021
Merged
galak pushed a commit that referenced this issue May 13, 2021
@dcpleung @galak
kernel: mmu: remove un-needed call to virt_to_bitmap_offset
216dc5d 
When marking the reserved region at the end of virtual address
space, call virt_to_bitmap_offset() is not needed as we already
know the offset. So remove it.

Coverity-CID: 235930
Fixes #35160

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcpleung dcpleung

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

kernel: mmu: remove un-needed call to virt_to_bitmap_offset dcpleung/zephyr
5 participants
@nashif @andyross @galak @zephyrbot @dcpleung