Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 392517] Logically dead code in subsys/bluetooth/host/classic/a2dp.c #74734

Closed
zephyrbot opened this issue Jun 22, 2024 · 2 comments · Fixed by #75369
Closed

[Coverity CID: 392517] Logically dead code in subsys/bluetooth/host/classic/a2dp.c #74734

zephyrbot opened this issue Jun 22, 2024 · 2 comments · Fixed by #75369
Assignees
@lylezhu2012
Labels
area: Bluetooth Classic Bluetooth Classic (BR/EDR) area: Bluetooth Host area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/dcf42917c550714d2457947538b9e29d083e872e/subsys/bluetooth/host/classic/a2dp.c

Category: Control flow issues
Function: a2dp_set_config_ind
Component: Bluetooth
CID: 392517

Details:

zephyr/subsys/bluetooth/host/classic/a2dp.c

Line 200 in dcf4291

*errcode = BT_AVDTP_BAD_ACP_SEID;

Please fix or provide comments in coverity using the link:

https://scan9.scan.coverity.com/#/project-view/29271/12996?selectedIssue=392517

For more information about the violation, check the Coverity Reference. (CWE-561)

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the MAINTAINERS file.
@zephyrbot zephyrbot added area: Bluetooth area: Bluetooth Host area: Bluetooth Classic Bluetooth Classic (BR/EDR) bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Jun 22, 2024
@jori-nordic jori-nordic removed their assignment Jul 2, 2024
@jhedberg jhedberg removed their assignment Jul 3, 2024
@jhedberg
Copy link
Member

jhedberg commented Jul 3, 2024

@lylezhu2012 any update here?

@lylezhu2012 lylezhu2012 mentioned this issue Jul 3, 2024
Merged
@lylezhu2012
Copy link
Contributor

@lylezhu2012 any update here?

PR is created for it.

AlienSarlak pushed a commit to AlienSarlak/zephyr that referenced this issue Jul 13, 2024
@lylezhu2012 @AlienSarlak
Bluetooth: A2DP: Check the pointer before using
eae8382 
Check the pointer `sep` before using it.

Fixes zephyrproject-rtos#74734.

Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
CZKikin pushed a commit to nxp-upstream/zephyr that referenced this issue Jul 18, 2024
@lylezhu2012 @CZKikin
Bluetooth: A2DP: Check the pointer before using
1864db2 
Check the pointer `sep` before using it.

Fixes zephyrproject-rtos#74734.

Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Devansh0210 pushed a commit to Devansh0210/zephyr that referenced this issue Jul 20, 2024
@lylezhu2012 @Devansh0210
Bluetooth: A2DP: Check the pointer before using
40a8a91 
Check the pointer `sep` before using it.

Fixes zephyrproject-rtos#74734.

Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Chenhongren pushed a commit to Chenhongren/zephyr that referenced this issue Aug 26, 2024
@lylezhu2012
Bluetooth: A2DP: Check the pointer before using
529cab4 
Check the pointer `sep` before using it.

Fixes zephyrproject-rtos#74734.

(cherry picked from commit c9708ff)

Original-Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
GitOrigin-RevId: c9708ff
Change-Id: Iccfdc1076259d05077c96921eaf590238392cc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5680119
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lylezhu2012 lylezhu2012

Labels
area: Bluetooth Classic Bluetooth Classic (BR/EDR) area: Bluetooth Host area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: A2DP: Check the pointer before using
4 participants
@jhedberg @zephyrbot @lylezhu2012 @jori-nordic