Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysbuild: ExternalZephyrProject_Add() cannot cope with hwmv2 board and revision #79208

Closed
nordicjm opened this issue Sep 30, 2024 · 0 comments · Fixed by #79209
Closed

sysbuild: ExternalZephyrProject_Add() cannot cope with hwmv2 board and revision #79208

nordicjm opened this issue Sep 30, 2024 · 0 comments · Fixed by #79209
Assignees
@nordicjm
Labels
area: Sysbuild bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@nordicjm
Copy link
Collaborator

Describe the bug
This function takes a board and a board revision, which it then uses to construct a string which is provided to the target image, this works fine for HWMv1 boards, but fails for HWMv2 boards, because it places it at the end, whereas in HWMv2 the version goes after the board name, before the SoC

Expected behavior
Feature to work

Impact
Showstopper

Environment (please complete the following information):

  • Commit SHA or Version used: main and v3.7-branch
@nordicjm nordicjm added bug The issue is a bug, or the PR is fixing a bug area: Sysbuild labels Sep 30, 2024
@nordicjm nordicjm self-assigned this Sep 30, 2024
nordicjm added a commit to nordicjm/zephyr that referenced this issue Sep 30, 2024
@nordicjm
sysbuild: cmake: Fix ExternalZephyrProject_Add() revision handling
dcce23c 
Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes zephyrproject-rtos#79208

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
@nordicjm nordicjm mentioned this issue Sep 30, 2024
Merged
@dkalowsk dkalowsk added the priority: low Low impact/importance bug label Oct 1, 2024
MaureenHelm pushed a commit that referenced this issue Oct 2, 2024
@nordicjm @MaureenHelm
sysbuild: cmake: Fix ExternalZephyrProject_Add() revision handling
96c6c78 
Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes #79208

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
@github-project-automation github-project-automation bot moved this from To do to Done in 3.4 in Build system Oct 2, 2024
zephyrbot pushed a commit that referenced this issue Oct 2, 2024
@nordicjm @github-actions
sysbuild: cmake: Fix ExternalZephyrProject_Add() revision handling
2086582 
Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes #79208

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
(cherry picked from commit 96c6c78)
@nordicjm nordicjm mentioned this issue Oct 4, 2024
Merged
masz-nordic pushed a commit to masz-nordic/zephyr that referenced this issue Oct 4, 2024
@nordicjm
[nrf fromlist] sysbuild: cmake: Fix ExternalZephyrProject_Add() revis…
8005d4e 
…ion handling

Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes zephyrproject-rtos#79208

Upstream PR: zephyrproject-rtos#79209

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
MarekPieta pushed a commit to MarekPieta/zephyr that referenced this issue Oct 7, 2024
@nordicjm @bjarki-andreasen
[nrf fromlist] sysbuild: cmake: Fix ExternalZephyrProject_Add() revis…
faed66f 
…ion handling

Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes zephyrproject-rtos#79208

Upstream PR: zephyrproject-rtos#79209

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
nashif pushed a commit that referenced this issue Oct 16, 2024
@nordicjm @nashif
sysbuild: cmake: Fix ExternalZephyrProject_Add() revision handling
cd43f1b 
Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes #79208

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
(cherry picked from commit 96c6c78)
doki-nordic pushed a commit to doki-nordic/zephyr that referenced this issue Oct 25, 2024
@nordicjm @rlubos
[nrf fromlist] sysbuild: cmake: Fix ExternalZephyrProject_Add() revis…
bcb795a 
…ion handling

Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes zephyrproject-rtos#79208

Upstream PR: zephyrproject-rtos#79209

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
(cherry picked from commit faed66f)
nordic-krch pushed a commit to nordic-krch/zephyr that referenced this issue Dec 11, 2024
@nordicjm @jukkar
[nrf fromlist] sysbuild: cmake: Fix ExternalZephyrProject_Add() revis…
f1ba687 
…ion handling

Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes zephyrproject-rtos#79208

Upstream PR: zephyrproject-rtos#79209

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
(cherry picked from commit faed66f)
(cherry picked from commit bcb795a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nordicjm nordicjm

Labels
area: Sysbuild bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Build system
Status: Done in 3.4
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sysbuild: cmake: Fix ExternalZephyrProject_Add() revision handling nordicjm/zephyr
2 participants
@dkalowsk @nordicjm