Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: flash: spi_nor: values vom DT not correctly used, when CONFIG_SPI_NOR_SFDP_RUNTIME=y #80383

Closed
maass-hamburg opened this issue Oct 24, 2024 · 5 comments · Fixed by #80365
Assignees
Labels
area: Flash bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@maass-hamburg
Copy link
Collaborator

Describe the bug

when CONFIG_SPI_NOR_SFDP_RUNTIME=y, configs from the dts like the wp, hold and reset pins are not parsed correctly into the struct spi_nor_config and therefore can't be used by the driver.

To Reproduce
set CONFIG_SPI_NOR_SFDP_RUNTIME=y, when using the jedec,spi-nor flash driver

Expected behavior
dts configuration is used correctly

Impact
most of the available configuration, that can be done via the dts wont work when CONFIG_SPI_NOR_SFDP_RUNTIME=y,

Logs and console output

Environment (please complete the following information):
NA

Additional context
Got introduced with #70415

@maass-hamburg maass-hamburg added bug The issue is a bug, or the PR is fixing a bug area: Flash labels Oct 24, 2024
@de-nordic de-nordic added the priority: low Low impact/importance bug label Oct 25, 2024
@de-nordic
Copy link
Collaborator

Bug level set to low, seems to go mainly undetected by users.

@de-nordic de-nordic added this to the v4.0.0 milestone Oct 25, 2024
@alexgoldstone
Copy link

This just bit me for several hours so its definitely impacting more than just the original reporter.

@de-nordic
Copy link
Collaborator

This just bit me for several hours so its definitely impacting more than just the original reporter.

Sorry. Have you reported that? It is hard to evaluate user impact without reports.

@alexgoldstone
Copy link

alexgoldstone commented Oct 25, 2024

No, it literally just occurred as an issue for us today and once I identified the problem I searched to see if anyone else had the same issue and commented above. Is there somewhere else I should flag this also please?

@de-nordic
Copy link
Collaborator

Ok, so you are the second person to report this since it went in as part of 3.7.0.
This is the right place to report it.

de-nordic added a commit to de-nordic/zephyr that referenced this issue Oct 30, 2024
de-nordic added a commit to de-nordic/zephyr that referenced this issue Oct 30, 2024
Release note update.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
mmahadevan108 pushed a commit that referenced this issue Nov 1, 2024
Release note update.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
cooked pushed a commit to cooked/zephyr that referenced this issue Nov 6, 2024
Release note update.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
andrewnyland pushed a commit to onceLabs/zephyr that referenced this issue Nov 6, 2024
Release note update.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Flash bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants