Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear definition of CONFIG_IS_BOOTLOADER #9566

Closed
JoeHut opened this issue Aug 22, 2018 · 9 comments
Closed

Unclear definition of CONFIG_IS_BOOTLOADER #9566

JoeHut opened this issue Aug 22, 2018 · 9 comments
Assignees
Labels
area: Miscellaneous Enhancement Changes/Updates/Additions to existing features platform: STM32 ST Micro STM32 priority: low Low impact/importance bug Waiting for response Waiting for author's response

Comments

@JoeHut
Copy link
Contributor

JoeHut commented Aug 22, 2018

The CONFIG_IS_BOOTLOADER option was apparently introduced by STM for disabling vector relocation on Cortex-M0. The naming or its usage is misleading since the config's help says "Zephyr will act as a bootloader to execute" but the config is selected in board files. What I would expect that this option is only used in applications that act as a bootloader such as MCUboot.

@nvlsianpu
Copy link
Collaborator

nvlsianpu commented Aug 22, 2018

CONFIG_IS_BOOTLOADER used to disable vector relocation mechanism which is specific for cortex-m0 stm32f0 family. Parallel to this feature some time ago we implemented generic cortex-m0 vector relocation (https://github.com/zephyrproject-rtos/zephyr/pull/4536/files). What I can suggest is to rename this keyword to something more suitable. I think feature enabled by this keyword is something vendor specific.

@nvlsianpu nvlsianpu added platform: STM32 ST Micro STM32 area: Miscellaneous priority: low Low impact/importance bug labels Aug 22, 2018
@nvlsianpu
Copy link
Collaborator

cc @erwango If you can answer in your convenience or redirect to someone (no rush).

@MaureenHelm MaureenHelm added the Enhancement Changes/Updates/Additions to existing features label Aug 22, 2018
@b0661
Copy link
Collaborator

b0661 commented Aug 23, 2018

CONFIG_IS_BOOTLOADER is used for the situation where you do not need vector relocation for the cortex-m0.

@SebastianBoe
Copy link
Collaborator

This issue relates to: #6180

@nvlsianpu
Copy link
Collaborator

CONFIG_IS_BOOTLOADER is used for the situation where you do not need vector relocation for the cortex-m0.

Ach yes, you are right.

@erwango
Copy link
Member

erwango commented Feb 15, 2019

CONFIG_IS_BOOTLOADER was introduced by 21628d4 so not introduced by or for STM.
Since authors do not contribute to zephyr anymore, maybe @andyross would be the right person for this point?

@erwango
Copy link
Member

erwango commented May 25, 2020

@JoeHut Is this issue still valid ?

@erwango erwango added the Waiting for response Waiting for author's response label May 25, 2020
@JoeHut
Copy link
Contributor Author

JoeHut commented May 25, 2020

We worked around it and I am currently not up to date with the 2.x branches since we stayed with the LTS. If noone else complains I guess you can close it.

@erwango
Copy link
Member

erwango commented May 25, 2020

Txs @JoeHut , I'm closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Miscellaneous Enhancement Changes/Updates/Additions to existing features platform: STM32 ST Micro STM32 priority: low Low impact/importance bug Waiting for response Waiting for author's response
Projects
None yet
Development

No branches or pull requests

6 participants