Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: test framework to validate the reproducible builds #11523

Closed

Conversation

ajaykish
Copy link
Contributor

A test framework to verify that builds are reproducible, i.e.
producing exactly the same binary. Validating the binary generated
from same directory, different directories and on different hosts
with same tool chain.

Signed-off-by: Ajay Kishore ajay.kishore@intel.com

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #11523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11523   +/-   ##
=======================================
  Coverage   48.22%   48.22%           
=======================================
  Files         279      279           
  Lines       43285    43285           
  Branches    10357    10357           
=======================================
  Hits        20875    20875           
  Misses      18270    18270           
  Partials     4140     4140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6a226...130c5aa. Read the comment docs.

@ajaykish ajaykish requested a review from nashif November 20, 2018 06:28
Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shell script needs major improvements, it needs to work as a test and cleanly from inside the zephyr tree without touch user homes and duplicating git trees.

Need documentation of what the scripts are doing and how to use them.

rm -rf /home/$USER/zephyr_src1
fi

if [ -d "/home/$USER/zephyr_src2" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/$USER = $HOME
and I would not put anything in home, please always use temporary directories with random names in /tmp or something like that.



mkdir /home/$USER/zephyr_src2
echo "Cloning latest code in zephyr_source2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we cloning Zephyr twice here? It is enough to build an application outside of Zephyr tree in 2 different location to test this.


if os.path.exists(input_file1):
if os.path.exists(input_file2):
subprocess.call("diffoscope --text filename {0} {1}". format(input_file1, input_file2), shell=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add this to python requirements

@@ -0,0 +1,75 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • header with python shebang
  • license
  • copyright
  • quick into into the script, what does it do, how to use it.

@ajaykish
Copy link
Contributor Author

@nashif I have addressed the comments and pushed a new patch.
Could you please review it.

A test framework to verify that builds are reproducible, i.e.
producing exactly the same binary. Validating the binary generated
from same directory, different directories and on different hosts
with same tool chain.

Signed-off-by: Ajay Kishore <ajay.kishore@intel.com>
@nashif
Copy link
Member

nashif commented Mar 28, 2019

obsoleted, we have other scripts providing this now.

@nashif nashif closed this Mar 28, 2019
@nashif
Copy link
Member

nashif commented Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants