drivers: nordic: usbd: Fix long (fragmented) control OUT transfers #11713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Review history of this comment for details about previous failed status. |
Codecov Report
@@ Coverage Diff @@
## master #11713 +/- ##
=======================================
Coverage 48.2% 48.2%
=======================================
Files 279 279
Lines 43312 43312
Branches 10372 10372
=======================================
Hits 20878 20878
Misses 18288 18288
Partials 4146 4146Continue to review full report at Codecov.
|
pawelzadrozniak
force-pushed
the
nordic_long_ctrl_read_fix
branch
from
27e0548 to
5b14641
Compare
Fragmented long CTRL OUT transfers does not work properly, because they were not handler properly by the shim. In such transfers, a special call (nrfx_usbd_setup_data_clear()) must be performed before every data packet and not just before the first one. This patch adds a byte counter which is set while processing setup packet (host->device only) to be able to decide whether there will be more data packets coming (and to call_data_clear() or not). Fixes zephyrproject-rtos#11232 . Signed-off-by: Paweł Zadrożniak <pawel.zadrozniak@nordicsemi.no>
pawelzadrozniak
force-pushed
the
nordic_long_ctrl_read_fix
branch
from
5b14641 to
0e5146a
Compare
carlescufi
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragmented long CTRL OUT transfers does not work properly, because
they were not handler properly by the shim. In such transfers,
a special call (nrfx_usbd_setup_data_clear()) must be performed
before every data packet and not just before the first one.
This patch adds a byte counter which is set while processing setup
packet (host->device only) to be able to decide whether there will
be more data packets coming (and to call_data_clear() or not).
Fixes #11232 .
Signed-off-by: Paweł Zadrożniak pawel.zadrozniak@nordicsemi.no