cmake: FindPythonInterp: Prioritize 'python' from path the highest #11907
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11907 +/- ##
=======================================
Coverage 48.16% 48.16%
=======================================
Files 281 281
Lines 43355 43355
Branches 10391 10391
=======================================
Hits 20883 20883
Misses 18318 18318
Partials 4154 4154Continue to review full report at Codecov.
|
| @@ -36,6 +36,45 @@ | |||
| # get the currently active Python version by default with a consistent version | |||
| # of PYTHON_LIBRARIES. | |||
|
|
|||
| function(determine_python_version exe result) | |||
| execute_process(COMMAND "${exe}" -c | |||
| "import sys; sys.stdout.write(';'.join([str(x) for x in sys.version_info[:3]]))" | |||
There was a problem hiding this comment.
Can use a generator expression: ';'.join(str(x) for x in foo)' works the same as ';'.join([str(x) for x in foo]).
There was a problem hiding this comment.
Why the ; that are then replaced with . by the way? A comment might be nice.
There was a problem hiding this comment.
Can use a generator expression: ';'.join(str(x) for x in foo)' works the same as ';'.join([str(x) for x in foo]).
This is out-of-scope of the PR. This code has only been moved, not modified, so it's contents are not up for review.
Users expect that not just "some" compatible python is detected, but also that it will be the 'python' executable from PATH, at least when this executable is valid. To this end rewrite FindPythonInterp to give this executable the highest priority. This fixes zephyrproject-rtos#11857 Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
force-pushed
the
fix_python_autodetection
branch
from
a66ab78 to
165302b
Compare
Fixed. |
@ulfalizer : Evidently, users have 19 year old python versions installed: #12066 (comment) |
Users expect that not just "some" compatible python is detected, but
also that it will be the 'python' executable from PATH, at least when
this executable is valid.
To this end rewrite FindPythonInterp to give this executable the
highest priority.
This fixes #11857
Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no