Soc arm cleanup systick #15212
Merged
Soc arm cleanup systick #15212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
added
Enhancement
ioannisg
requested review from
erwango,
fallrisk,
galak,
Mani-Sadhasivam,
MaureenHelm,
vanti and
ydamigos
as code owners
|
All checks are passing now. Review history of this comment for details about previous failed status. |
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
from
88fd5cf to
022e070
Compare
ulfalizer
approved these changes
Apr 5, 2019
pizi-nordic
approved these changes
Apr 5, 2019
andyross
approved these changes
Apr 5, 2019
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
from
022e070 to
e082309
Compare
Will do, thanks. Done now @ulfalizer |
ydamigos
approved these changes
Apr 8, 2019
erwango
approved these changes
Apr 11, 2019
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
3 times, most recently
from
1f26fd4 to
a7ae2e6
Compare
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
3 times, most recently
from
a949ffe to
0e25fdc
Compare
26 tasks
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
from
0e25fdc to
522c2c0
Compare
CPU_CORTEX_M does not need to be selected by Kconfig symbols that already select a CORTEX_M variant. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ARM SysTick timer is implemented by default in ARMv7-M and Mainline ARMv8-M processors, so we include the corresponding Kconfig symbol in arch/arm/core/cortex-M/Kconfig and remove the selections from the Cortex-M SOCs. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
This commit renames the symbol CPU_HAS_SYSTICK to CPU_CORTEX_M_HAS_SYSTICK, to look similar to all other CPU_CORTEX_M_HAS_ options, and moves the K-config symbol definition from arm/core/Kconfig to arm/core/cortex_m/Kconfig. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
We shall not enable by default a system timer in ARM platforms, namely the SysTick, the Nordic, or the SAM0 RTC timer, simply by assessing the hardware capabilities (e.g. by conditioning on CPU_CORTEX_M_HAS_SYSTICK). Instead, now, all ARM platforms needs to explicitly set their system timer module. Note that this has already been the case for ca 80% of the ARM platforms. This clean-up allows us to decouple HW capabilities from system configuration (for example, Nordic platforms may enable option CPU_CORTEX_M_HAS_SYSTICK, and still use the platform-specific RTC timer for system timing). Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ioannisg
force-pushed
the
soc_arm_cleanup_systick
branch
from
522c2c0 to
46a530c
Compare
|
@carlescufi @galak @MaureenHelm, some help needed on this one - CI times-out continuously, due to the patch introducing changes in a relatively high number of platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR clean-up the inconsistencies with SysTick In ARM platforms:
CPU_HAS_SYSTICKselection in ARCH for ARMv7-M and ARMv8-M Mainline architecturesCPU_CORTEX_M_HAS_SYSTICK, to look similar to all otherCORTEX_M__HASoptions.In addition, the PR cleans up some left-out direct
CPU_CORTEX_MSelections in ARM SOCs.The main reason for the patch (besides the obvious enhancement of clean-up) is to decouple HW capability options (CPU_HAS_) from system configuration.