Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: arm: move z_clearfaults() in kernel_arch_init() #16169

Conversation

ioannisg
Copy link
Member

In kernel_arch_init() we initialize the ARM core (interrupt
setup, fault init, etc.) so we can also move z_clearfaults()
in the same function and skip invoking it in the SoC init
functions.

Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no

@ioannisg ioannisg added the RFC Request For Comments: want input from the community label May 15, 2019
@ioannisg ioannisg requested a review from carlescufi May 15, 2019 07:54
@ioannisg ioannisg changed the title soc: arm: move z_clearfaults() in kernel_arch_init() [RFC] soc: arm: move z_clearfaults() in kernel_arch_init() May 15, 2019
@ioannisg ioannisg added area: ARM ARM (32-bit) Architecture area: optimization labels May 15, 2019
@ioannisg ioannisg requested a review from pizi-nordic May 15, 2019 07:59
Copy link
Collaborator

@agansari agansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay on NXP SoCs.
I can imagine a corner-case scenario where someone would want to check boot time exceptions, but this isn't happening in the current code base and has a small probability.

@ioannisg
Copy link
Member Author

Looks okay on NXP SoCs.
I can imagine a corner-case scenario where someone would want to check boot time exceptions, but this isn't happening in the current code base and has a small probability.

How about STM32 @erwango ?

@andrewboie
Copy link
Contributor

I can imagine a corner-case scenario where someone would want to check boot time exceptions, but this isn't happening in the current code base and has a small probability.

This is a private API, if we want to support that it needs to be promoted to public anyway
Private z_ APIs can change move or be deleted at any time.

@ioannisg ioannisg changed the title [RFC] soc: arm: move z_clearfaults() in kernel_arch_init() soc: arm: move z_clearfaults() in kernel_arch_init() May 16, 2019
In kernel_arch_init() we initialize the ARM core (interrupt
setup, fault init, etc.) so we can also move z_clearfaults()
in the same function and skip invoking it in the SoC init
functions.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg ioannisg force-pushed the soc_arm_move_clear_faults_in_arch_init branch from 3757d06 to a8d94b3 Compare May 17, 2019 11:37
@andrewboie andrewboie merged commit fb713aa into zephyrproject-rtos:master May 17, 2019
@Sizurka Sizurka mentioned this pull request May 21, 2019
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARM ARM (32-bit) Architecture area: optimization RFC Request For Comments: want input from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants