Migrate DesignWare I2C driver to new PCIe system #16222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2019 13:19
This option is no longer used in the dts_fixup.h file since there are no SBL-specific fixups. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
This needs to be pushed down to the SoC level, as it's an Apollo Lake feature, not a feature of the UpSquared. Remove the Apollo Lake references to the PCI devices because these will not be used when I2C support is restored. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
The SBL configuration no longer differs in any detail (except its name) from the "standard" UpSquared configuration, so it is removed. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
ghost
requested review from
ghost
added
|
I have physically confirmed the driver still works properly on a galileo with an I2C blinkM. |
|
All checks are passing now. Review history of this comment for details about previous failed status. |
added 4 commits
May 16, 2019 18:40
The 50-odd lines of boilerplate per I2C port is moved into a template which is generated by CMake as needed at build-time. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
The legacy PCI support in the DesignWare I2C driver is replaced with the new PCIe support. The Intel Quark X1000 SoC and the galileo board configurations are updated accordingly. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
The Apollo Lake devicetree is augmented with its 8 I2C interfaces. The default number of dynamic IRQ stubs is increased to deal with these new interfaces having IRQ vector detection at runtime. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
I2C support has been added back into the up_squared, leveraging the new PCIe support in the DesignWare I2C driver. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
andyross
approved these changes
May 17, 2019
andrewboie
reviewed
May 17, 2019
andrewboie
approved these changes
May 17, 2019
|
Force-push to restart CI checks after @ulfalizer's updates. |
|
CI fix merged now. |
|
recheck Looks like |
Mark myself (reluctant) owner of the Designware I2C driver. Signed-off-by: Charles E. Youse <charles.youse@intel.com>
Yeah. I've force-pushed again.. fingers crossed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects the galileo and up_squared boards, as they are the only targets that use the PCI functionality of the driver. I've refactored a few things to make adding future Apollo Lake targets easier.
Fixes: #13963