tests: kernel: submit a simple test for zero-latency irqs #17045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
|
All checks are passing now. Review history of this comment for details about previous failed status. |
ioannisg
force-pushed
the
tests_kernel_zero_latency_irqs
branch
from
aa82340 to
2fef862
Compare
nordic-krch
reviewed
Jun 25, 2019
| @@ -0,0 +1,20 @@ | |||
| /* | |||
There was a problem hiding this comment.
why is it split into two files?
There was a problem hiding this comment.
I suppose, I just followed the arm_irq_vector_table test structure
ioannisg
force-pushed
the
tests_kernel_zero_latency_irqs
branch
from
2fef862 to
6c0ab49
Compare
|
@cvinayak could you also take a quick look? |
carlescufi
reviewed
Jun 25, 2019
ioannisg
force-pushed
the
tests_kernel_zero_latency_irqs
branch
2 times, most recently
from
24b2869 to
14c6700
Compare
carlescufi
reviewed
Jun 25, 2019
| zassert_false(test_flag, "Test flag not initialized to zero\n"); | ||
|
|
||
| for (i = CONFIG_NUM_IRQS - 1; i >= 0; i--) { | ||
| if (NVIC_GetEnableIRQ(i) == 0) { |
There was a problem hiding this comment.
Can you add a comment as to why GetEnableIRQ() allows you to find an available interrupt?
There was a problem hiding this comment.
Something like what we have in line 22?
There was a problem hiding this comment.
Or a more detailed comment, e.g.
/*
* Interrupts configured statically with IRQ_CONNECT(..) are automatically enabled. NVIC_GetEnableIRQ() returning
* false implies that the IRQ line is not currently in use by Zephyr.
*/
14c6700 to
fb7f9da
Compare
The commit contributes a simple test for the Zero-Latency IRQ feature (CONFIG_ZERO_LATENCY_IRQS=y) for ARM platforms. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Add the arm tag to tests/kernel/arm_runtime_nmi test. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ioannisg
force-pushed
the
tests_kernel_zero_latency_irqs
branch
from
fb7f9da to
b95a719
Compare
andrewboie
approved these changes
Jun 25, 2019
nordic-krch
approved these changes
Jun 26, 2019
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16901
The commit contributes a simple test for the Zero-Latency
IRQ feature (CONFIG_ZERO_LATENCY_IRQS=y) for ARM platforms.
Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no