Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: k64f MPU configured to always allow USB #17834

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

agansari
Copy link
Collaborator

@agansari agansari commented Jul 29, 2019

Because NXP MPU's regions are dynamically enabled/disabled, USB
device's access maybe restricted when switching out of a task.
Background DMA transfers to/from RAM may happen during MPU region
reconfiguration or core idling.
Enabled USB (Kinetis MPU Master 4) to always have access to RAM address
space.

Signed-off-by: Andrei Gansari andrei.gansari@nxp.com

Fixes #17007

Because NXP MPU's regions are dynamically enabled/disabled, USB
device's access maybe restricted when switching out of a task.
Background DMA transfers to/from RAM may happen during MPU region
reconfiguration or core idling.
Enabled USB (Kinetis MPU Master 4) to always have access to RAM address
space.

Signed-off-by: Andrei Gansari <andrei.gansari@nxp.com>
@ioannisg ioannisg added the bug The issue is a bug, or the PR is fixing a bug label Jul 30, 2019
@ioannisg ioannisg added this to the v2.0.0 milestone Jul 30, 2019
@ioannisg
Copy link
Member

@agansari one last question - this needs to be back-ported, right? Did we back-port your other similar fix ?

@agansari
Copy link
Collaborator Author

@ioannisg yes, the last patch was backported to v1.14

@ioannisg
Copy link
Member

@agansari actually, is is "to-be-backported", right?
#17641

@agansari
Copy link
Collaborator Author

Yes, that's it i was looking for #17603

@ioannisg
Copy link
Member

Yes, that's it i was looking for #17603

Ok, then we just back-port the current patch as well

@ioannisg ioannisg merged commit 11d8f1a into zephyrproject-rtos:master Jul 30, 2019
@backporting
Copy link

backporting bot commented Jul 30, 2019

The backport to v1.14-branch failed:

Commits ["65fd912ac2624e41ab5868d91d0fef81cd86955d"] could not be cherry-picked on top of v1.14-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v1.14-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 65fd912ac2624e41ab5868d91d0fef81cd86955d
# Create a new branch with these backported commits.
git checkout -b backport-17834-to-v1.14-branch
# Push it to GitHub.
git push --set-upstream origin backport-17834-to-v1.14-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v1.14-branch and the compare/head branch is backport-17834-to-v1.14-branch.

@MaureenHelm
Copy link
Member

@agansari the automatic backport failed, will you please create a manual backport PR to the 1.14-branch?

@ioannisg
Copy link
Member

ioannisg commented Aug 6, 2019

I think he can't because the patch is based on the earlier similar fix, whose back-port PR has not been merged to 1.14 yet

@agansari agansari deleted the k64f_usb_mpu branch December 9, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Memory Protection area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USB mass demo format fails on frdm_k64f
4 participants