Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/x86: remove support for IAMCU ABI #18604

Merged
merged 1 commit into from Sep 7, 2019
Merged

arch/x86: remove support for IAMCU ABI #18604

merged 1 commit into from Sep 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2019

This ABI is no longer required by any targets and is deprecated.

Fixes: #17888

Signed-off-by: Charles E. Youse charles.youse@intel.com

@ghost ghost requested review from nashif, andyross, ceolin, andrewboie, dcpleung, a user and jenmwms August 23, 2019 03:05
@ghost ghost requested review from dbkinder, SebastianBoe and wentongwu as code owners August 23, 2019 03:05
@nashif nashif added this to the v2.1.0 milestone Aug 23, 2019
@galak
Copy link
Collaborator

galak commented Aug 23, 2019

I take this PR to mean its ok to drop the iamcu toolchain build from SDK-ng.

@ghost
Copy link
Author

ghost commented Aug 23, 2019

I take this PR to mean its ok to drop the iamcu toolchain build from SDK-ng.

Yep.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM. remember to add this to the 2.0 release notes

@dbkinder dbkinder added the Release Notes To be mentioned in the release notes label Aug 27, 2019
@ghost
Copy link
Author

ghost commented Aug 30, 2019

doc changes LGTM. remember to add this to the 2.0 release notes

Added a commit to update the release notes for this feature removal.

This ABI is no longer required by any targets and is deprecated.

Signed-off-by: Charles E. Youse <charles.youse@intel.com>
@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 30, 2019

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@ghost
Copy link
Author

ghost commented Aug 30, 2019

Added a commit to update the release notes for this feature removal.

@dbkinder I've backed out this commit since this is marked for 2.1, not 2.0

@dbkinder
Copy link
Contributor

doh. OK.

@ghost ghost closed this Sep 4, 2019
@ghost ghost reopened this Sep 5, 2019
@nashif nashif merged commit 6767563 into zephyrproject-rtos:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Boards area: Build System area: Documentation area: X86 x86 Architecture (32-bit) Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arch/x86: remove IAMCU ABI support
6 participants