Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc: arm: st_stm32: stm32g4: STM32G4 support #18806

Merged
merged 17 commits into from
Oct 5, 2019
Merged

soc: arm: st_stm32: stm32g4: STM32G4 support #18806

merged 17 commits into from
Oct 5, 2019

Conversation

rosterloh
Copy link
Contributor

Add support for STM32G4 series

Signed-off-by: Richard Osterloh richard.osterloh@gmail.com

@rosterloh
Copy link
Contributor Author

Requires PR from stm32_hal zephyrproject-rtos/hal_stm32#20

@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 30, 2019 •
edited
Loading

Found the following issues, please fix and resubmit:

Identity/Emails issues

022fcf72fb832b30536281d0e1e724ea9ddd8ee1: author email (Erwan Gouriou erwan.gouriou@linaro.org) needs to match one of the signed-off-by entries.

@loicpoulain
Copy link
Collaborator

loicpoulain commented Aug 30, 2019 •
edited
Loading

It would be worth to split the PR into several commits, e.g. one for the SoC support, one for the new board(s) support...

@galak galak added the platform: STM32 ST Micro STM32 label Sep 1, 2019
@rosterloh
Copy link
Contributor Author

Split the commit as requested by @loicpoulain and added copyright dues zephyrbot warnings

erwango
erwango reviewed Sep 2, 2019
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosterloh , thanks for this change with this wide range of updated drivers.
Did you had time to test everything?
As mentioned by @loicpoulain, it eases the review when change is split in several small commits.
Here is an example of split PR that was done for L1 port: #12354
I fully understand it is more initial work for author, but since review work is getting easier, upstream goes faster overall.

@rosterloh
Copy link
Contributor Author

rosterloh commented Sep 2, 2019 •
edited
Loading

@erwango I've done the following tests:

  • samples/blinky
  • samples/button
  • samples/fade_led

@erwango
Copy link
Member

erwango commented Sep 2, 2019

@rosterloh

@erwango I've done the following tests:

Ok, then please focus your commits on drivers actually validated: clock, gpio, interrupt_controller.
And remove reference (in doc, dts, driver modifications, ...) for whatever was not validated yet: SPI, I2C, ADC, PWM, UART, ....
These will be added later on, either by you when you have time or by other community members that will take advantage of your initial basic port.

@rosterloh
Copy link
Contributor Author

rosterloh commented Sep 2, 2019 •
edited
Loading

@erwango I've validated everything I've checked in. Just pushed a few fixes in and additional commit. clock, gpio, i2c, interrupt_controller, pwm, led, pinmux, serial, spi and usb all working.

I've also submitted a PR to your openocd repo to provide G4 support there. I've been doing all my testing with it so am happy it works.

erwango
erwango requested changes Sep 3, 2019
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosterloh, thanks for the work so far, looks promising.
To get merged there is some additional work that will be requested:

  • get automatic checks passing (shippable + checkpatch (you can let the ">80 char" warning for now))
  • split the PR into subsystem commits (as mentioned already L1 port (Add 96Boards WisTrio board support #12354) is a good example of what is expected). This is requested to ease the review work and has been followed for all other series porting PRs.
  • Squash the "fix commit" into the previous commits

Thanks

@rosterloh
Copy link
Contributor Author

@erwango Woo Hoo! All passed.

@erwango erwango added the DNM This PR should not be merged (Do Not Merge) label Sep 30, 2019
@erwango
Copy link
Member

erwango commented Sep 30, 2019

Approved, but last point will be to update west.yml file once zephyrproject-rtos/hal_stm32#20 is merged.
Tagged DNM until this is done.

@martinjaeger martinjaeger mentioned this pull request Oct 2, 2019
Closed
@galak
Copy link
Collaborator

galak commented Oct 4, 2019

Approved, but last point will be to update west.yml file once zephyrproject-rtos/hal_stm32#20 is merged.
Tagged DNM until this is done.

Merged the HAL repo change.

rosterloh and others added 17 commits October 4, 2019 15:58
@rosterloh
ext: hal: st: stm32cube: Add HAL for the STM32G4x series
7289c91 
This commit adds the STM32CUBE HAL for STM32G4x series MCUs.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
soc: arm: st_stm32: Add STM32G4 SoC series
f828c86 
Add soc and dts files to support for most of the common peripherals
in the STM32G4 series. Add specific support for the STM32G431RB.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: clock_control: Add STM32G4X clock support
09303f9 
Add clock support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: pinmux: Add STM32G4X pinmux support
fceb160 
Add pinmux support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: gpio: Add STM32G4X gpio support
370777d 
Add GPIO driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: interrupt_controller: Add STM32G4X exti support
bcf9234 
Add EXTI driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: serial: Add STM32G4X serial support
bc16a73 
Add UART driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: flash: Add STM32G4X flash support
0283bb4 
Add flash driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: i2c: Add STM32G4X I2C support
9efe3c3 
Add I2C driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: spi: Add STM32G4X SPI support
01dfb0f 
Add SPI driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: adc: Add STM32G4X ADC support
6cb42f4 
Add ADC driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@erwango @rosterloh
drivers: pwm: Add STM32G4X PWM Support
c142a7a 
Add PWM driver support for STM32G4X SoC series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: counter: Add STM32G4X counter support
2c52cfd 
Add counter driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: entropy: Add STM32G4X RNG support
d1d50b0 
Add RNG driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
drivers: usb: Add STM32G4X USB support
83585fe 
Add USB driver support for STM32G4X SoC series.

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@erwango @rosterloh
drivers: watchdog: Add STM32G4x Watchdog support
b2a74d6 
Add watchdog driver support for STM32G4X SoC series.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
boards: arm: Add support for Nucleo G431RB board
590621e 
Nucleo-G431RB board support and description

Signed-off-by: Richard Osterloh <richard.osterloh@gmail.com>
@rosterloh
Copy link
Contributor Author

@erwango @galak made the west.yaml change

@erwango erwango removed the DNM This PR should not be merged (Do Not Merge) label Oct 4, 2019
@erwango erwango requested a review from galak October 4, 2019 15:27
@andrewboie andrewboie merged commit df5edf6 into zephyrproject-rtos:master Oct 5, 2019
@rosterloh rosterloh deleted the stm32g4-support branch October 7, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@galak galak galak approved these changes

@dbkinder dbkinder dbkinder approved these changes

@ioannisg ioannisg ioannisg approved these changes

@andrewboie andrewboie Awaiting requested review from andrewboie

@finikorg finikorg Awaiting requested review from finikorg

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@loicpoulain loicpoulain Awaiting requested review from loicpoulain

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@rsalveti rsalveti Awaiting requested review from rsalveti

@superna9999 superna9999 Awaiting requested review from superna9999

@ydamigos ydamigos Awaiting requested review from ydamigos

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

Assignees
No one assigned
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Boards area: Counter area: Devicetree area: I2C area: Modules area: SPI SPI bus platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rosterloh @zephyrbot @loicpoulain @erwango @ioannisg @galak @dbkinder @andrewboie