arch: arm: cmse: re-introduce workaround for typeof

[ioannisg]

The GNU ARM Embedded "8-2019-q3-update" toolchain
erroneously uses "typeof" instead of "typeof".
To work around this we define typeof to be able to
support it.

This reverts commit 01a71ea.

Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no

[ioannisg]

Relates to #19182

[galak]

Can we add some gcc version checking. Thus it will be clear if/when we might want to remove this in the future.

[ioannisg]

Can we add some gcc version checking. Thus it will be clear if/when we might want to remove this in the future.

That's what I wanted to avoid, @galak ; have ifdefs with toolchain versions. Like this , the workaround is more generic and not strictly coupled with a GCC release.

It, simply, defines the intrinsic if not already defined

[galak]

Hmm, than maybe a comment about some versions of gcc-8 being broken.

[ioannisg]

Hmm, than maybe a comment about some versions of gcc-8 being broken.

@galak something like:

/* Required for C99 compilation (required for GCC-8 where typeof
 * is used instead of __typeof__)
 */

???

[galak]

@galak something like:

/* Required for C99 compilation (required for GCC-8 where typeof
 * is used instead of __typeof__)
 */

???

Yes, but something like required for GCC-8.1 & GCC-8.2. It sounded like from @sigvartmh that GCC-8.3 has the fix.

[ioannisg]

@galak something like:

/* Required for C99 compilation (required for GCC-8 where typeof
 * is used instead of __typeof__)
 */

???

Yes, but something like required for GCC-8.1 & GCC-8.2. It sounded like from @sigvartmh that GCC-8.3 has the fix.

Right, I 'l ll add the minor versions, too.

[sigvartmh]

@galak No I had patched my toolchain files when I tried it yesterday, forgot I had done that.

So all versions of arm-none-eabi-gcc 8 are bad for arm_cmse.h

[ioannisg]

@galak No I had patched my toolchain files when I tried it yesterday, forgot I had done that.

So all versions of arm-none-eabi-gcc 8 are bad for arm_cmse.h

@galak I updated the comment based on the feedback from @sigvartmh