Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: peci: Add Platform Environment Control Interface API #22575

Merged
merged 9 commits into from
Mar 13, 2020
Merged

API: peci: Add Platform Environment Control Interface API #22575

merged 9 commits into from
Mar 13, 2020

Conversation

albertofloyd
Copy link
Collaborator

@albertofloyd albertofloyd commented Feb 7, 2020 •
edited
Loading

Platform Environment Control Interface, abbreviated as PECI, is a thermal management standard introduced in 2006, while the spec allows to retrieve temperature it also allows to retrieve additional information and/or update other properties involved in thermal management.

API: peci: Add Platform Environment Control Interface API

Add Platform Environment Control Interface API
This API defines following calls:

- peci_configure
- peci_enable
- peci_disable
- peci_transfer

@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 7, 2020 •
edited
Loading

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@albertofloyd albertofloyd force-pushed the peci branch 3 times, most recently from aa3b157 to 63812d4 Compare February 7, 2020 19:18
@albertofloyd albertofloyd force-pushed the peci branch 2 times, most recently from 3b7e0cf to 0b372d2 Compare February 7, 2020 21:42
franciscomunoz
franciscomunoz suggested changes Feb 7, 2020
View reviewed changes
include/drivers/peci.h Outdated Show resolved Hide resolved
drivers/peci/Kconfig Outdated Show resolved Hide resolved
dts/arm/microchip/mec1501hsz.dtsi Outdated Show resolved Hide resolved
dts/bindings/peci/microchip,xec-peci.yaml Outdated Show resolved Hide resolved
doc/reference/peripherals/peci.rst Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
samples/drivers/peci/src/main.c Outdated Show resolved Hide resolved
@franciscomunoz franciscomunoz mentioned this pull request Feb 10, 2020
Merged
andrewboie
andrewboie suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@andrewboie andrewboie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See notes about system calls. Have a look at other driver _handlers.c files for examples. Please contact me if you're unsure what needs to be done.

drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
include/drivers/peci.h Outdated Show resolved Hide resolved
@albertofloyd
Copy link
Collaborator Author

@andrewboie peci_handlers.c updated based on can_handlers.c as requested

andrewboie
andrewboie suggested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@andrewboie andrewboie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this build? didn't see a change to gen_kobject_list.py to add the peci API type.

drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
@albertofloyd
Copy link
Collaborator Author

does this build? didn't see a change to gen_kobject_list.py to add the peci API type.
Yes, a sample peci app does build correctly when enabling CONFIG_USERSPACE with a dummy driver for frdm_k64f.

andrewboie
andrewboie suggested changes Feb 12, 2020
View reviewed changes
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
andrewboie
andrewboie suggested changes Feb 13, 2020
View reviewed changes
include/drivers/peci.h Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
andrewboie
andrewboie suggested changes Mar 11, 2020
View reviewed changes
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
include/drivers/peci.h Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
drivers/peci/peci_handlers.c Outdated Show resolved Hide resolved
include/drivers/peci.h Outdated Show resolved Hide resolved
@albertofloyd albertofloyd force-pushed the peci branch 2 times, most recently from 0209f1c to 06871aa Compare March 12, 2020 23:23
@albertofloyd
API: peci: Add Platform Environment Control Interface API
5fa0fd2 
Add Platform Environment Control Interface API
This API defines following calls:

- peci_configure
- peci_enable
- peci_disable
- peci_transaction

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
doc: reference: peripherals: Add PECI API documentation
c37d1f1 
Add PECI API documentation

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
soc: arm: microchip: Expose PECI feature on MEC1501 SoC
299acda 
Define PECI_XEC feature.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
drivers: peci: Add Kconfig for PECI driver
2c7c312 
Add the Kconfig for generic PECI drivers.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
dts: peci: Add dts bindings for PECI
af014e9 
Add generic device tree bindings for PECI devices

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
dts: peci: mchp: Add dts bindings for XEC PECI driver
ac685ee 
Add device for PECI driver for MEC family

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
andrewboie
andrewboie approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@andrewboie andrewboie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK leave handlers out for now, but please file a GH enhancement for them.

franciscomunoz
franciscomunoz approved these changes Mar 13, 2020
View reviewed changes
boards/arm/mec1501modular_assy6885/pinmux.c Outdated Show resolved Hide resolved
samples/drivers/peci/src/main.c Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
drivers/peci/peci_mchp_xec.c Outdated Show resolved Hide resolved
drivers/peci/CMakeLists.txt Outdated Show resolved Hide resolved
@albertofloyd
drivers: peci: Add PECI driver for microchip XEC family
f609327 
Add PECI driver that support PECI API.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
samples: drivers: peci: Add PECI driver sample app
72f2266 
Sample code that showcase PECI API get device CPU information
then monitors temperature.
Verified in Modular MEC1501 connected to computer (PECI host).

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
boards : arm : Add PECI support for MEC15xx EVB
551c0e8 
Enable PECI block for MEC15 boards.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd
Copy link
Collaborator Author

OK leave handlers out for now, but please file a GH enhancement for them.

#23432

@andrewboie andrewboie merged commit 8462a37 into zephyrproject-rtos:master Mar 13, 2020
@albertofloyd albertofloyd deleted the peci branch April 8, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcpleung dcpleung dcpleung approved these changes

@franciscomunoz franciscomunoz franciscomunoz approved these changes

@andrewboie andrewboie andrewboie approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@ioannisg ioannisg Awaiting requested review from ioannisg

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@scottwcpg scottwcpg Awaiting requested review from scottwcpg

Assignees
No one assigned
Labels
area: API Changes to public APIs area: Boards area: Devicetree area: Documentation area: Modules area: Samples Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@albertofloyd @zephyrbot @andrewboie @franciscomunoz @dcpleung