kernel: random: ifdef z_early_boot_rand_get

[ceolin]

This function had a to sys_rand_get() even without random source. As Zephyr is
built with linkage garbage collection and this function is called only if
either STACK_CANARIES or STACK_POINTER_RANDOM is enabled and these options
automatically enable a random source.

Signed-off-by: Flavio Ceolin flavio.ceolin@intel.com

[ceolin]

Fixes #20136

[zephyrbot]

All checks are passing now.

checkpatch (informational only, not a failure)

-:17: WARNING:LONG_LINE_COMMENT: line over 80 characters
#17: FILE: kernel/init.c:483:
+/* defined(CONFIG_ENTROPY_HAS_DRIVER) || defined(CONFIG_TEST_RANDOM_GENERATOR) */

- total: 0 errors, 1 warnings, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

[stephanosio]

IMHO, making it #ifdef CONFIG_ENTROPY_GENERATOR would be better as that is really what determines the availability of z_early_boot_rand_get.

[ceolin]

@stephanosio Can you take a look again ?