Bluetooth: controller: legacy: Fix DLE duplicate requests #23708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the Data Length Update Procedure state check when processing incoming LENGTH_REQ/RSP PDUs. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix implementation to handle back-to-back and duplicate LENGTH_REQ PDU reception. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
added
backport v2.2-branch
bug
dagbja
approved these changes
Mar 24, 2020
kruithofa
reviewed
Mar 26, 2020
| _radio.conn_curr->llcp_length.ack) && | ||
| (pdu_data_rx->llctrl.opcode == | ||
| PDU_DATA_LLCTRL_TYPE_LENGTH_REQ)) || | ||
| _radio.conn_curr->llcp_length.ack) && node_tx) || |
There was a problem hiding this comment.
Same comment as in #23707; IMHO the original was easier to read
carlescufi
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implementation to handle back-to-back and duplicate
LENGTH_REQ PDU reception.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no