Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: latency_measure: disable power management #24163

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

dcpleung
Copy link
Member

@dcpleung dcpleung commented Apr 7, 2020

Disable power management by setting CONFIG_SYS_POWER_MANAGEMENT=n
for this test. This is to prevent power management from
interfering with latency measurement.

Signed-off-by: Daniel Leung daniel.leung@intel.com

@dcpleung dcpleung requested a review from nashif as a code owner April 7, 2020 20:11
@dcpleung dcpleung requested a review from chen-png April 7, 2020 20:12
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Apr 7, 2020
@nashif
Copy link
Member

nashif commented Apr 7, 2020

we probably should disable power management for everyone, not only this board.

@dcpleung dcpleung force-pushed the mec1501_latency_benchmark branch from d91bd2d to 1005788 Compare April 7, 2020 22:02
@dcpleung dcpleung changed the title tests: latency_measure: disable pm for mec15xxevb_assy6853 tests: latency_measure: disable power management Apr 7, 2020
@dcpleung
Copy link
Member Author

dcpleung commented Apr 7, 2020

we probably should disable power management for everyone, not only this board.

Updated to disable PM for all.

@dcpleung dcpleung force-pushed the mec1501_latency_benchmark branch 2 times, most recently from eab752f to e1f96e2 Compare April 8, 2020 01:57
Disable power management by setting CONFIG_SYS_POWER_MANAGEMENT=n
for this test. This is to prevent power management from
interfering with latency measurement.

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Copy link
Collaborator

@chen-png chen-png left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, now the test is passed.

Disable power management for boards mec15xxevb_assy6853 and
mec1501modular_assy6885 on latency_measure test. This prevents
the SoC from sleeping which may skew the results. Also this
prevents stopping mid-test due to SoC being in sleep state,
and there are no external interrupts to wake up the SoC.

Fixes zephyrproject-rtos#24136

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung dcpleung force-pushed the mec1501_latency_benchmark branch from e1f96e2 to 660ba6b Compare April 8, 2020 06:00
@nashif nashif merged commit 67d220d into zephyrproject-rtos:master Apr 11, 2020
@dcpleung dcpleung deleted the mec1501_latency_benchmark branch April 12, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Tests Issues related to a particular existing or missing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants