Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXP: LPC: various cleanups #24368

Merged
merged 8 commits into from
Apr 17, 2020
Merged

NXP: LPC: various cleanups #24368

merged 8 commits into from
Apr 17, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Apr 15, 2020

  • cleanup and refactoring of LPC55S6x and LPC54xxx device trees
  • Remove stale Kconfig options related to LPC support
  • Get lpcxpresso55s69_ns building
  • Move to nodelabel's for pinmux enablement

galak added 4 commits April 15, 2020 00:14
@galak
dts: arm: nxp: lpc54xxx: Move SRAM nodes under SoC
c7ca218 
As the SRAMs are part of the SoC put the nodes under the SoC container
node.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak
boards: arm: lpcxpresso55s69: Get non-secure config building
06bdbaa 
Fix various board files and nxp_lpc55S6x_ns.dtsi to get the non-secure
config building.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak
dts: arm: nxp: nxp_lpc55s6x: Move sram nodes under SoC
cc19321 
Move sram nodes under soc as it is for most SoC dts files.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak
dts: arm: nxp: nxp_lpc55s6x: Refactor devicetree
d4bc4b6 
Move the majority of the device tree into nxp_lpc55S6x_common.dtsi and
use ranges to handle the different address may for non-secure.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak added the platform: NXP NXP label Apr 15, 2020
@zephyrbot
Copy link
Collaborator

zephyrbot commented Apr 15, 2020 •
edited
Loading

All checks passed.

checkpatch (informational only, not a failure)

-:11: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11: FILE: boards/arm/lpcxpresso54114/pinmux.c:27:
+    DT_NODE_HAS_COMPAT(DT_NODELABEL(flexcomm0), nxp_lpc_usart)$

-:39: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#39: FILE: boards/arm/lpcxpresso54114/pinmux.c:112:
+    DT_NODE_HAS_COMPAT(DT_NODELABEL(flexcomm4), nxp_lpc_i2c)$

-:52: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: boards/arm/lpcxpresso54114/pinmux.c:133:
+    DT_NODE_HAS_COMPAT(DT_NODELABEL(flexcomm5), nxp_lpc_spi)$

-:160: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: boards/arm/lpcxpresso55s69/pinmux.c:27:
+    DT_NODE_HAS_COMPAT(DT_NODELABEL(flexcomm0), nxp_lpc_usart)$

-:170: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: boards/arm/lpcxpresso55s69/pinmux.c:92:
+    DT_NODE_HAS_COMPAT(DT_NODELABEL(flexcomm4), nxp_lpc_i2c)$

-:520: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "arm,cortex-m33f" appears un-documented -- check ./dts/bindings/
#520: FILE: dts/arm/nxp/nxp_lpc55S6x_common.dtsi:23:
+			compatible = "arm,cortex-m33f";

- total: 0 errors, 6 warnings, 852 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

MaureenHelm
MaureenHelm requested changes Apr 15, 2020
View reviewed changes
dts/arm/nxp/nxp_lpc55S6x_common.dtsi
@@ -204,12 +204,14 @@
status = "disabled";
};

flexcomm8: flexcomm@9f000 {
compatible = "nxp,lpc-flexcomm";
hs_lspi: spi@9f000 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did the "l" come from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its what is used in the NXP HAL. hs_lspi/hs_spi seem to be intermixed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/zephyrproject-rtos/hal_nxp/blob/87850e41cd48e4472adbae03c9623ea349255d48/mcux/devices/LPC55S69/fsl_clock.h#L258

dts/arm/nxp/nxp_lpc55S6x_common.dtsi Show resolved Hide resolved
boards/arm/lpcxpresso54114/pinmux.c Outdated Show resolved Hide resolved
galak added 3 commits April 15, 2020 13:50
@galak
dts: arm: nxp: nxp_lpc55s6x: Fix high speed SPI node
9858a8b 
The flexcomm at 0x9f000 is a high speed SPI interface only.  Tweak the
device tree to reflect that.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak
dts: arm: nxp: nxp_lpc55s6x: Remove GPIO2/3 nodes
7a9905c 
GPIO2/GPIO3 don't exist on the lpc55s6x so remove these nodes and
associated aliases.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak
drivers: gpio: mcux_lpc: Remove unused Kconfig symbols
c283675 
CONFIG_GPIO_MCUX_LPC_PORT0_NAME and CONFIG_GPIO_MCUX_LPC_PORT1_NAME
aren't used anywhere so we can just remove them.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak requested a review from tbursztyka as a code owner April 15, 2020 18:51
@galak galak requested a review from MaureenHelm April 15, 2020 18:51
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Apr 15, 2020
MaureenHelm
MaureenHelm requested changes Apr 16, 2020
View reviewed changes
boards/arm/lpcxpresso54114/pinmux.c Outdated Show resolved Hide resolved
@galak
boards: arm: nxp: lpc: Convert from Kconfig to DT_NODELABEL
4e655b7 
As prep for drivers being converted to utilize DT_INST and removal of
per instance Kconfig symbols, move board pinmux.c code to utilize
DT_NODELABEL instead.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak requested a review from MaureenHelm April 16, 2020 21:03
This was referenced Apr 17, 2020
Closed
Closed
@galak
Copy link
Collaborator Author

galak commented Apr 17, 2020

Fixes #24439

@galak galak linked an issue Apr 17, 2020 that may be closed by this pull request
LPCXpresso55S69_ns target : build failed #24439
Closed
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Apr 17, 2020
@MaureenHelm MaureenHelm merged commit 5e73787 into zephyrproject-rtos:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@mnkp mnkp Awaiting requested review from mnkp

@pabigot pabigot Awaiting requested review from pabigot

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

Assignees
No one assigned
Labels
area: Boards area: Devicetree area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LPCXpresso55S69_ns target : build failed
4 participants
@galak @zephyrbot @henrikbrixandersen @MaureenHelm