hal_st: Make it a zephyr library. #25061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisconti
approved these changes
May 7, 2020
|
Seems it doesn't work as expected |
Strange. To be honest I'm not able to get why CI is breaking. I'm not able to download the logs. |
|
@avisconti I think I got it: I was declaring |
|
@avisconti Interesting failure remains as it seems we should not share HAS_STLIB |
erwango
requested review from
jhedberg,
joerchan,
nashif and
Vudentz
as code owners
joerchan
approved these changes
May 8, 2020
erwango
changed the title
galak
approved these changes
May 8, 2020
Both ST and STM32 modules where using same HAS_STLIB Kconfig symbol. Now that each module is createing is own lib, we need to be able to distinguish libs. Depends on zephyrproject-rtos/hal_stm32/pull/52 Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Depends on zephyrproject-rtos/hal_st/pull/4 Fixes zephyrproject-rtos#19614 Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on zephyrproject-rtos/hal_st/pull/4 and zephyrproject-rtos/hal_stm32/pull/52
Fixes #19614
Signed-off-by: Erwan Gouriou erwan.gouriou@linaro.org