Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: Revert "qemu_x86: use icount for 32-bit" #25094

Merged

Conversation

andrewboie
Copy link
Contributor

@andrewboie andrewboie commented May 7, 2020

This was causing problems on some network tests.

This reverts commit 9b055ec.

Fixes: #25083

Signed-off-by: Andrew Boie andrew.p.boie@intel.com

This was causing problems on some network tests.

This reverts commit 9b055ec.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
@andrewboie andrewboie requested a review from nashif as a code owner May 7, 2020 17:32
@andrewboie andrewboie requested review from pfalcon and jukkar May 7, 2020 17:32
@andrewboie
Copy link
Contributor Author

Revert until we can investigate further.

@andrewboie andrewboie added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label May 7, 2020
@andrewboie andrewboie requested a review from carlescufi May 7, 2020 17:33
Copy link
Contributor

@pfalcon pfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this fixes the issue for me. Tested with samples/net/sockets/dumb_http_server.

@pfalcon pfalcon requested a review from ozhuraki May 7, 2020 17:50
@pfalcon
Copy link
Contributor

pfalcon commented May 7, 2020

Perhaps include "Fixes: #25083" in the commit message?

@andrewboie
Copy link
Contributor Author

Perhaps include "Fixes: #25083" in the commit message?

added

@andrewboie andrewboie requested a review from wentongwu May 7, 2020 18:01
@andrewboie andrewboie merged commit d2dce5e into zephyrproject-rtos:master May 7, 2020
@andrewboie andrewboie deleted the revert-qemu-icount-x86 branch May 7, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Networking samples are not able to connect with the TCP under qemu_x86 after 9b055ec
6 participants