Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsys/testsuite: Shorten the assertion messages #25110

Merged
merged 1 commit into from
May 13, 2020

Conversation

sjg20
Copy link
Collaborator

@sjg20 sjg20 commented May 7, 2020

At present these can be very long since they include the full path of
the filename with the error.

Assertion failed at /home/sglass/cosarm/zephry/zephyrproject/
zephyr/tests/drivers/flash_simulator/src/main.c:102:
test_write_read: (0 not equal to rc)

Reduce the length by omitting the current directory (where the tests
are being run) from the output:

Assertion failed at tests/drivers/flash_simulator/src/main.c:102:
test_write_read: (0 not equal to rc)

This improves usability for people running tests locally.

Signed-off-by: Simon Glass sjg@chromium.org

@sjg20 sjg20 requested a review from nashif as a code owner May 7, 2020 21:54
@nashif nashif added this to the v2.3.0 milestone May 10, 2020
@nashif
Copy link
Member

nashif commented May 10, 2020

ci stuck, close/reopen

@nashif nashif closed this May 10, 2020
@nashif nashif reopened this May 10, 2020
@sjg20
Copy link
Collaborator Author

sjg20 commented May 11, 2020

Something seems to be wrong with the checks here. I tried twice and these three seem to be broken:

  • Gitlint
  • Identity/Emails
  • Kconfig

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are running into an issue that should hopefully fixed by https://github.com/zephyrproject-rtos/ci-tools/pull/135/files

At present these can be very long since they include the full path of
the filename with the error.

    Assertion failed at /home/sglass/cosarm/zephry/zephyrproject/
	zephyr/tests/drivers/flash_simulator/src/main.c:102:
	test_write_read: (0 not equal to rc)

Reduce the length by omitting the current directory (where the tests
are being run) from the output:

    Assertion failed at tests/drivers/flash_simulator/src/main.c:102:
	test_write_read: (0 not equal to rc)

This improves usability for people running tests locally.

Signed-off-by: Simon Glass <sjg@chromium.org>
@zephyrbot zephyrbot added the area: Test Framework Issues related not to a particular test, but to the framework instead label May 11, 2020
@carlescufi carlescufi merged commit 4b2c413 into zephyrproject-rtos:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Test Framework Issues related not to a particular test, but to the framework instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants