lib: updatehub: Add missing include for FLASH_AREA #25333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion from DT_FLASH_AREA to FLASH_AREA macros don't add the storage flash_map.h include file. Fixes: zephyrproject-rtos#25332 Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
nandojve
added
the
Trivial
otavio
approved these changes
May 15, 2020
galak
approved these changes
May 15, 2020
erwango
added
bug
|
I'd like to understand how this breakage has not been spotted by the CI system? This is something we should verify so we avoid these build failures in the future. |
|
Looking on the CI result, it runned all CI checks so our sample is not enabled for it. @nandojve can we enable it to be tested on CI? |
Based on the current platform a warning can raise becase of missing string.h include file. Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
Add missing sample.yaml file to enable CI build tests. Local tests can be executed executing sanitycheck: ./scripts/sanitycheck -l --testcase-root samples/net/updatehub Signed-off-by: Gerson Fernando Budke <gerson.budke@ossystems.com.br>
|
Two new commits: |
carlescufi
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion from DT_FLASH_AREA to FLASH_AREA macros don't add the
storage flash_map.h include file.
Fixes: #25332
Signed-off-by: Gerson Fernando Budke gerson.budke@ossystems.com.br