usb: doc: Add note about cdc+dfu Windows OS exception. #25347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eobalski
added
bug
carlescufi
approved these changes
May 19, 2020
|
@jfischer-phytec-iot take a quick look please? |
jfischer-no
requested changes
May 19, 2020
carlescufi
requested changes
May 20, 2020
| @@ -1,5 +1,7 @@ | |||
| # Overlay file for composite configuration | |||
| # CDC ACM + USB DFU | |||
| # | |||
| # This composite configuration may not work for Windows OS. | |||
There was a problem hiding this comment.
Can you add the info in the commit message in this file as well?
Add a note for composite (CDC+DFU) device overlay. Composite device CDC+DFU may not work with Windows OS host. Windows OS does not send reset after DFU_DETACH request (does not re-enumerates) and thus make it unable for the device to restart in DFU mode. For more details refer to zephyrproject-rtos#23337. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>
eobalski
force-pushed
the
usb_composite_cdc_dfu
branch
from
a02194f to
e00d063
Compare
carlescufi
approved these changes
May 21, 2020
|
@jfischer-phytec-iot can you revisit this one please? |
jfischer-no
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note for composite (CDC+DFU) device overlay.
Composite device CDC+DFU may not work with Windows OS host.
Windows OS does not send reset after DFU_DETACH request
(does not re-enumerates) and thus make it unable for
the device to restart in DFU mode.
Closes #23337.
Signed-off-by: Emil Obalski emil.obalski@nordicsemi.no