sample/drivers/counter/alarm: adapt test to driver change PR #25367 #25371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
force-pushed
the
SAMPLE_COUNTER_TOLERANCE
branch
from
c9470d7 to
ecb912b
Compare
erwango
added
area: Counter
bug
gmarull
reviewed
May 18, 2020
| @@ -8,6 +8,8 @@ Overview | |||
| This sample provides an example of alarm application using counter API. | |||
| It sets an alarm with an initial delay of 2 seconds. At each alarm | |||
| expiry, a new alarm is configured with a delay multiplied by 2. | |||
| Note: In case of 1Hz frequency (RTC for example), precision is 1 second. | |||
| Now value can be slightly different than the one in Sample Output | |||
There was a problem hiding this comment.
Use RST notes, e.g.
.. note::
In case of....I'd suggest Therefore, the sample output may differ in 1 second instead of Now value can be slightly different than the one in Sample Output
There was a problem hiding this comment.
Docs build is broken, can you check?
ABOSTM
force-pushed
the
SAMPLE_COUNTER_TOLERANCE
branch
from
ecb912b to
21f7a08
Compare
…rproject-rtos#25367 Due to counter driver implementation change introduced with PR zephyrproject-rtos#25367 "driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm" It is necessary to adapt sample test (sanitycheck) to take into consideration 1 tick precision/tolerance. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
SAMPLE_COUNTER_TOLERANCE
branch
from
21f7a08 to
8301aa1
Compare
|
Commit added to #25367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to counter driver implementation change introduced with PR #25367
"driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm"
It is necessary to adapt sample test (sanitycheck)
to take into consideration 1 tick precision/tolerance.
Fixes #25366