-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: eth: stm32: Fix invalid assertion check #25428
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:master
from
bwasim:stm32-eth-assert-failure
May 19, 2020
Merged
drivers: eth: stm32: Fix invalid assertion check #25428
carlescufi
merged 1 commit into
zephyrproject-rtos:master
from
bwasim:stm32-eth-assert-failure
May 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for assertion on the "config_func" was added to validate that the function pointer is valid. However, in the code we are invoking the "config_func" and comparing its output with NULL. This causes build failures with CONFIG_ASSERT=1. Caused by PR-25393. Tested on Nucleo F767Zi board. Fixes zephyrproject-rtos#25427 Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
Build failure in shippable not seen under #25393, but seen under #25397.. Here's the log,
|
bwasim
changed the title
drivers: eth: stm32: Fix invalid assertion comparison
drivers: eth: stm32: Fix invalid assertion check
May 18, 2020
jukkar
approved these changes
May 19, 2020
erwango
approved these changes
May 19, 2020
erwango
added
the
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
label
May 19, 2020
pfalcon
approved these changes
May 19, 2020
jukkar
added
the
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
label
May 19, 2020
@carlescufi: Can you please merge this, there're reports that it breaks CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Ethernet
bug
The issue is a bug, or the PR is fixing a bug
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
platform: STM32
ST Micro STM32
priority: high
High impact/importance bug
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for assertion on the "config_func" was added to validate that the function pointer is valid. However, in the code we are invoking the "config_func" and comparing its output with NULL. This causes build failures with CONFIG_ASSERT=1. Caused by PR-25393.
Tested on Nucleo F767Zi board.
Fixes #25427
Signed-off-by: Bilal Wasim bilalwasim676@gmail.com