DT-related fixes in UART driver for CC13xx/CC26xx #25647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The power configuration is dependent on which UART is physically used. In order to allow DT_INST_FOREACH_STATUS_OKAY() to iterate through instances without the assumption that index 0 corresponds to UART0 (which would be incorrect in the case when only UART1 is enabled), we need to check the base address to identify which UART is being dealt with. Signed-off-by: Vincent Wan <vincent.wan@linaro.org>
There does not seem to be a simple way to express the fact that UART1 can be initialized later at the POST_KERNEL level. The existing code is wrong in the sense that it always initializes DT instance 1 later, instead of doing it for UART1 (which may not be instance 1). In addition, UART instances on other platforms are also initialized at the PRE_KERNEL_1 level regardless of the instance index, so let's do the same on this platform for consistency. Signed-off-by: Vincent Wan <vincent.wan@linaro.org>
galak
approved these changes
May 27, 2020
galak
added
area: Devicetree
area: UART
carlescufi
approved these changes
May 27, 2020
This was referenced May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing driver code, after changes from the recent DT rework, does
not allow UART1 to be enabled when UART0 is not. This is because there
is an implicit assumption that DT instance 0 corresponds to UART0 and
DT instance 1 corresponds to UART1.
In particular, the power configuration is dependent on which UART is physically used.
In order to allow DT_INST_FOREACH_STATUS_OKAY() to iterate through
instances without the assumption that index 0 corresponds to UART0
(which would be incorrect in the case when only UART1 is enabled),
we need to check the base address to identify which UART is being dealt
with.
There also does not seem to be a simple way to express the fact that UART1
can be initialized later at the POST_KERNEL level. The existing code
is wrong in the sense that it always initializes DT instance 1 later,
instead of doing it for UART1 (which may not be instance 1).
In addition, UART instances on other platforms are
also initialized at the PRE_KERNEL_1 level regardless of the instance
index, so let's do the same on this platform for consistency.