Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: compression: lz4: lz4 sample application #28536

Merged
merged 1 commit into from
Jun 12, 2021
Merged

samples: compression: lz4: lz4 sample application #28536

merged 1 commit into from
Jun 12, 2021

Conversation

Navin-Sankar
Copy link
Member

@Navin-Sankar Navin-Sankar commented Sep 19, 2020 •
edited
Loading

This PR add sample application for minimal lz4 library.

lz4 library RFC requested here: #28535

Fixes: #26648

Signed-off-by: NavinSankar Velliangiri navin@linumiz.com

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 2 times, most recently from 5390f7a to e20f747 Compare September 19, 2020 15:28
@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch from e20f747 to 5e7021f Compare September 19, 2020 17:34
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 19, 2020
@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 3 times, most recently from 379a3ce to b73d432 Compare November 19, 2020 04:32
@github-actions github-actions bot closed this Dec 4, 2020
@Navin-Sankar Navin-Sankar reopened this Dec 4, 2020
@Navin-Sankar
Copy link
Member Author

@carlescufi requesting for review.

@jukkar jukkar removed the Stale label Dec 4, 2020
parthitce referenced this pull request in linumiz/zephyr Feb 5, 2021
@parthitce
samples: application_development: lz4 library
3c56fce 
Add sample application for lz4 data compression and decompression.

Signed-off-by: NavinSankar Velliangiri <navin@linumiz.com>
@carlescufi carlescufi added the DNM This PR should not be merged (Do Not Merge) label Feb 10, 2021
@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 2 times, most recently from 94b42df to 55bf582 Compare February 28, 2021 12:35
@MaureenHelm
Copy link
Member

Looks like a bad SHA in west.yml is causing checks to fail:

fatal: update_ref failed for ref 'refs/heads/manifest-rev': cannot update ref 'refs/heads/manifest-rev': trying to write ref 'refs/heads/manifest-rev' with nonexistent object eda8cc259715f17e3a8ca9f5e74f89a5aa503709
ERROR: update failed for project lz4

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 2 times, most recently from e0b943e to 523ef62 Compare March 2, 2021 12:47
@MaureenHelm
Copy link
Member

@carlescufi the manifest action doesn't seem to be detecting this change

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch from 523ef62 to 9d31e49 Compare March 16, 2021 02:03
mniestroj
mniestroj requested changes May 5, 2021
View reviewed changes
samples/compression/lz4/src/main.c Outdated Show resolved Hide resolved
samples/compression/lz4/prj.conf Outdated Show resolved Hide resolved
@carlescufi
Copy link
Member

@Navin-Sankar could you please address the review comments?

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch from 7f72c9c to 66f64db Compare May 6, 2021 10:17
@Navin-Sankar
Copy link
Member Author

@carlescufi please revisit.

mniestroj
mniestroj requested changes May 6, 2021
View reviewed changes
samples/compression/lz4/sample.yaml Outdated Show resolved Hide resolved
samples/compression/lz4/sample.yaml Outdated Show resolved Hide resolved
samples/compression/lz4/sample.yaml Outdated Show resolved Hide resolved
@mniestroj
Copy link
Member

@Navin-Sankar please also update commit message, as it still says "Currently the west module dependency points to https://github.com/linumiz/lz4" which is not true anymore.

@carlescufi carlescufi removed this from the v2.6.0 milestone May 6, 2021
@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 2 times, most recently from d2c4524 to 06ec106 Compare May 6, 2021 15:04
@carlescufi carlescufi requested a review from mniestroj May 6, 2021 17:10
@carlescufi
Copy link
Member

@Navin-Sankar you have actual failures in buildkite, please take a look at them and fix them:
https://buildkite.com/zephyr/zephyr/builds/29402

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 3 times, most recently from 76de41d to 529e62e Compare May 7, 2021 08:46
@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 2 times, most recently from 766d3ff to c9772ea Compare May 8, 2021 04:26
mniestroj
mniestroj approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@mniestroj mniestroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build failure is not related to this PR.

@Navin-Sankar
Copy link
Member Author

@carlescufi please take another look. the build failure is not related to this pr.

@mniestroj
Copy link
Member

@Navin-Sankar could you rebase on main to make sure nothing breaks in the meantime? This can hopefully solve the unrelated build failure we have now.

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch from c9772ea to 4331057 Compare June 11, 2021 08:54
@carlescufi
Copy link
Member

carlescufi commented Jun 11, 2021 •
edited
Loading

@carlescufi please take another look. the build failure is not related to this pr.

@Navin-Sankar the compliance error is an actual issue:

4331057690e27e5ebf9cb3082f13e2fb11c9dfed: author email (NavinSankar Velliangiri <navin@linumiz.com>) needs to match one of the signed-off-by entries.

Check your Git email vs the signed-off-by line one to make sure they are the same.

@Navin-Sankar Navin-Sankar force-pushed the linumiz-compression-lz4 branch 3 times, most recently from 2d327e7 to 273ca64 Compare June 11, 2021 14:58
samples: compression: lz4: lz4 sample application
273ca64 
This PR add sample application for minimal lz4 library.

lz4 library RFC requested here: zephyrproject-rtos#28535

Fixes: zephyrproject-rtos#26648

Signed-off-by: NavinSankar Velliangiri <navin@linumiz.com>
@carlescufi
Copy link
Member

Thanks you @Navin-Sankar will merge this today.

@carlescufi carlescufi merged commit c9aa260 into zephyrproject-rtos:main Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm left review comments

@parthitce parthitce parthitce left review comments

@jukkar jukkar jukkar left review comments

@carlescufi carlescufi carlescufi approved these changes

@mniestroj mniestroj mniestroj approved these changes

@tejlmand tejlmand tejlmand approved these changes

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

@ioannisg ioannisg Awaiting requested review from ioannisg

Assignees
No one assigned
Labels
area: Documentation area: Modules area: Samples Samples manifest manifest-lz4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data compression module integration
7 participants
@Navin-Sankar @MaureenHelm @parthitce @carlescufi @mniestroj @jukkar @tejlmand