kernel: add k_heap_aligned_alloc #30003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyross
previously requested changes
Nov 13, 2020
kernel/kheap.c
Outdated
| @@ -51,6 +51,31 @@ void *k_heap_alloc(struct k_heap *h, size_t bytes, k_timeout_t timeout) | |||
| return ret; | |||
| } | |||
|
|
|||
| void *k_heap_aligned_alloc(struct k_heap *h, size_t align, size_t bytes, k_timeout_t timeout) | |||
There was a problem hiding this comment.
Rather than cutting and pasting the synchronization as boilerplate from k_heap_alloc(), could you please refactor the two so they use the same implementation? One simple option would be to implement k_heap_alloc() in terms of k_heap_aligned_alloc(). Or if we care about the mild performance overhead (IMHO we don't) implement both in terms of an inline function where the alignment code optimizes away.
andrewboie
approved these changes
Nov 13, 2020
|
Looks good now. CI failure looks like some infrastructure problem, can you rebase and push again, see if it goes away? |
cfriedt
approved these changes
Nov 16, 2020
cfriedt
reviewed
Nov 20, 2020
This was referenced Nov 20, 2020
k_heap did not have an aligned alloc function, even though this is supported by the internal sys_heap. Signed-off-by: Maximilian Bachmann <m.bachmann@acontis.com>
|
@andyross can you re-review this |
andyross
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k_heap did not have an aligned alloc function, even though
this is supported by the internal sys_heap. (implements #29631)
@andrewboie in #29029 you wrote that
k_heap has a facility for aligned allocations you should use that instead of k_malloc to reserve memory, but apparently this is not possible for k_heap yet