kernel: Kconfig: increase test default MAIN_STACK_SIZE #31865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
approved these changes
Feb 2, 2021
ioannisg
requested changes
Feb 2, 2021
kernel/Kconfig
Outdated
| @@ -150,7 +150,7 @@ config SCHED_CPU_MASK | |||
| config MAIN_STACK_SIZE | |||
| int "Size of stack for initialization and main thread" | |||
| default 2048 if COVERAGE_GCOV | |||
| default 512 if ZTEST && !(RISCV || X86) | |||
| default 768 if ZTEST && !(RISCV || X86) | |||
There was a problem hiding this comment.
Pls, make this 1024;
768 is not a power-of-2, and Cortex-M builds on ARMv7-M with Userspace will move to 1024 anyway... So putting 1024 will be less confusing.
Alternatively (since your primary target is ARM Cortex-M) you can add a new default line before line 153:
default 1024 if TEST_ARM_CORTEX_M
There was a problem hiding this comment.
So you won't be changing the default setting for other ARCHes like Xtensa, Sparc, AARC64 and ARC
There are more and more tests that fail due to stackoverflow. Increasing MAIN_STACK_SIZE to fix those issues. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
INCREASE_MAIN_STACK_SIZE
branch
from
b3c9d2c to
08ef875
Compare
ioannisg
approved these changes
Feb 2, 2021
erwango
approved these changes
Feb 2, 2021
|
@nashif that's for v2-5-0 release, imho |
ioannisg
added
area: ARM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several reasons to increase MAIN_STACK_SIZE for test purpose:
activation of CONFIG_FPU_SHARING by default when CONFIG_FPU is enabled for ARM arch (see ARM: Make FPU Sharing the default mode and activate Lazy FP stacking dynamically #31772)
This increase stack usage and requires MAIN_STACK_SIZE enlargement.
more and more tests failed due to stackoverflow.
And it concerns several boards: stm32f3_disco and nucleo_f746zg
Arbitrary increase from 512 to 768.
This fixes above issues.
No regression found on STM32 test bench.