Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: deprecate old k_work API #32888

Merged
merged 2 commits into from
May 7, 2021

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Mar 4, 2021

Several functions and macros have been replaced with new ones that conform to current naming conventions, or provide more functionality mostly through using new representations for delayable work. Mark these functions deprecated.

See: #29618 (comment)

Fixes part of #34105 by retaining the tests of the deprecated API while disabling the deprecation warnings that would be produced while the deprecated API is still present. The alternative conflicting approach is in #34112.

Draft until mainline has been updated to remove all uses except for explicit tests of the deprecated API.

@galak
Copy link
Collaborator

galak commented May 4, 2021

@pabigot will you update this to get merged or should I take over this PR? Happy to handle it either way, as we are getting close to having all in-tree users converted over.

@pabigot pabigot force-pushed the nordic/20210304b branch from 1c7152d to 46c9b4b Compare May 4, 2021 20:03
@pabigot
Copy link
Collaborator Author

pabigot commented May 4, 2021

@galak Updated. Do you have the ability to take this out of draft? If so please go ahead and do so when the time comes; otherwise let me know. I still check in at least once a day.

@galak
Copy link
Collaborator

galak commented May 4, 2021

@galak Updated. Do you have the ability to take this out of draft? If so please go ahead and do so when the time comes; otherwise let me know. I still check in at least once a day.

Thanks. Looks like I'm able to mark this as 'ready for review' to take it out of draft. So will do that one things are ready.

@galak
Copy link
Collaborator

galak commented May 5, 2021

Pulled in the bluetooth PR to get some CI cycles with this to see if catch anything we might have missed.

@galak galak force-pushed the nordic/20210304b branch from 1cbb6fb to 3312779 Compare May 6, 2021 21:33
@galak galak marked this pull request as ready for review May 6, 2021 21:33
@galak galak requested review from andyross and dcpleung as code owners May 6, 2021 21:33
@galak galak force-pushed the nordic/20210304b branch from 3312779 to 3822ce7 Compare May 7, 2021 01:06
@github-actions github-actions bot added area: Modules manifest west manifest-sof DNM This PR should not be merged (Do Not Merge) labels May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
sof zephyrproject-rtos/sof@2f8ef20 zephyrproject-rtos/sof#10 zephyrproject-rtos/sof#10/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@galak galak force-pushed the nordic/20210304b branch 2 times, most recently from ffc991c to f7e398e Compare May 7, 2021 21:42
pabigot added 2 commits May 7, 2021 16:51
Legacy k_work API has been marked deprecated, but it is still present
in tree and should be tested.  Avoid CI warnings by disabling warnings
on use of deprecated API within the test source files.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Several functions and macros have been replaced with new ones that
conform to current naming conventions, or provide more functionality,
mostly through using new representations for delayable work.  Mark
these functions deprecated.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
@galak galak force-pushed the nordic/20210304b branch from f7e398e to 49b1511 Compare May 7, 2021 21:52
@galak galak removed the DNM This PR should not be merged (Do Not Merge) label May 7, 2021
@galak galak merged commit 09a31ce into zephyrproject-rtos:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants