-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: deprecate old k_work API #32888
Conversation
8e6e598
to
3b8f03c
Compare
3b8f03c
to
1c7152d
Compare
@pabigot will you update this to get merged or should I take over this PR? Happy to handle it either way, as we are getting close to having all in-tree users converted over. |
@galak Updated. Do you have the ability to take this out of draft? If so please go ahead and do so when the time comes; otherwise let me know. I still check in at least once a day. |
Thanks. Looks like I'm able to mark this as 'ready for review' to take it out of draft. So will do that one things are ready. |
Pulled in the bluetooth PR to get some CI cycles with this to see if catch anything we might have missed. |
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
ffc991c
to
f7e398e
Compare
Legacy k_work API has been marked deprecated, but it is still present in tree and should be tested. Avoid CI warnings by disabling warnings on use of deprecated API within the test source files. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Several functions and macros have been replaced with new ones that conform to current naming conventions, or provide more functionality, mostly through using new representations for delayable work. Mark these functions deprecated. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Several functions and macros have been replaced with new ones that conform to current naming conventions, or provide more functionality mostly through using new representations for delayable work. Mark these functions deprecated.
See: #29618 (comment)
Fixes part of #34105 by retaining the tests of the deprecated API while disabling the deprecation warnings that would be produced while the deprecated API is still present. The alternative conflicting approach is in #34112.
Draft until mainline has been updated to remove all uses except for explicit tests of the deprecated API.