mgmt/osdp: Fix couple of issues identified by coverity #33098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a coverity identified, off-by-one, out-of-bound array access at pd->cap[]. CID: 215379 Fixes: zephyrproject-rtos#33095 Signed-off-by: Siddharth Chandrasekaran <siddharth@embedjournal.com>
sidcha
added
Coverity
nashif
approved these changes
Mar 7, 2021
ceolin
approved these changes
Mar 10, 2021
A previous check and return for (maxlen <= 0) makes manlen at least 1 so checks for (maxlen < 1) would never evaluate to true. Remove these checks and merge those cases into one. CID: 215392 Fixes: zephyrproject-rtos#33092 Signed-off-by: Siddharth Chandrasekaran <siddharth@embedjournal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix couple of issues identified by coverity.
Fixes: #33095
Fixes: #33092