Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up clock interfaces and remove tickless idle #33302

Merged
merged 14 commits into from
Mar 19, 2021
Merged

Clean up clock interfaces and remove tickless idle #33302

merged 14 commits into from
Mar 19, 2021

Conversation

nashif
Copy link
Member

@nashif nashif commented Mar 12, 2021

  • clock: remove z_ from semi-public APIs
  • doc: clocks: link clock APIs from doxygen
  • clock: rename z_timer_cycle_get_32 -> clock_cycle_get_32
  • kernel: remove tickless idle
  • drivers: arcv2_timer0: fix comment

@nashif nashif requested a review from a user March 12, 2021 19:37
nashif added 11 commits March 19, 2021 08:39
@nashif
drivers: arcv2_timer0: fix comment
d003521 
Comment talking about z_timer_int_handler which does not exist, replace
with timer_int_handler.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: z_clock_isr -> sys_clock_isr
7ebbfcf 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: z_clock_device_ctrl -> sys_clock_device_ctrl
c2050dc 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
sys_lock: extra 'needed' removed
202d48c 
Minor typo fix.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: rename z_clock_hw_cycles_per_sec_runtime_get
846f92e 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: rename z_tick_get_32 -> sys_clock_tick_get_32
e6f9989 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clocks: rename z_tick_get -> sys_clock_tick_get
0ee4f20 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: renmae z_timeout_end_calc -> sys_clock_timeout_end_calc
b105440 
Do not use z_ for internal APIs, z_ is for private APIs within one
subsystem only.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
clock: remove unused z_ms_to_ticks
d2f7416 
z_ms_to_ticks is not being used anywhere.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
kernel: remove tickless idle
78dddee 
This feature predated the tickless kernel and has been in legacy mode
for a while. We now have no drivers or systems that do not support
tickless, so remove this option and cleanup the code to only use
tickless.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
hal_ti: update to use k_ms_to_ticks_ceil32
cd1b29f 
z_ms_to_ticks is deprecated, so use k_ms_to_ticks_ceil32.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif force-pushed the clock/fix_api_and_remove_z branch from 9ac619b to cd1b29f Compare March 19, 2021 12:39
@nashif nashif requested review from stephanosio and removed request for VenkatKotakonda March 19, 2021 12:39
@nashif nashif merged commit 9b84921 into zephyrproject-rtos:master Mar 19, 2021
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this pull request Apr 23, 2021
@trond-snekvik
usb: dfu: convert z_timeout_end_calc to sys_clock_timeout_end_calc
e43fb0b 
The z_timeout_end_calc function was replaced by
sys_clock_timeout_end_calc in zephyrproject-rtos#33302. A reference to the old function
snuck into master through zephyrproject-rtos#30015.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@trond-snekvik trond-snekvik mentioned this pull request Apr 23, 2021
Merged
carlescufi pushed a commit that referenced this pull request Apr 26, 2021
@trond-snekvik @carlescufi
usb: dfu: convert z_timeout_end_calc to sys_clock_timeout_end_calc
6976658 
The z_timeout_end_calc function was replaced by
sys_clock_timeout_end_calc in #33302. A reference to the old function
snuck into master through #30015.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@albertofloyd albertofloyd mentioned this pull request Apr 28, 2021
Closed
jori-nordic pushed a commit to jori-nordic/zephyr that referenced this pull request May 4, 2021
@trond-snekvik
[nrf fromtree] usb: dfu: convert z_timeout_end_calc to
e688c7f 
...sys_clock_timeout_end_calc

The z_timeout_end_calc function was replaced by
sys_clock_timeout_end_calc in zephyrproject-rtos#33302. A reference to the old function
snuck into master through zephyrproject-rtos#30015.

(cherry picked from commit 6976658 ("usb: dfu: convert
z_timeout_end_calc to sys_clock_timeout_end_calc"))
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@biglben biglben mentioned this pull request Mar 22, 2022
Merged
mbrunnen added a commit to ithinx-io/zephyr that referenced this pull request May 10, 2023
@mbrunnen
doc: Remove tickless idle from PM in introduction
e4b3ea4 
Tickless idle has been replaced by the tickless kernel and also power
management has become much more advanced.

See also: zephyrproject-rtos#33302

Signed-off-by: Manoel Brunnen <mb@lee-brunnen.de>
@mbrunnen mbrunnen mentioned this pull request May 10, 2023
Merged
mbrunnen added a commit to ithinx-io/zephyr that referenced this pull request May 24, 2023
@mbrunnen
doc: Remove tickless idle from PM in introduction
e530e4b 
Tickless idle has been replaced by the tickless kernel and also power
management has become much more advanced.

See also: zephyrproject-rtos#33302

Signed-off-by: Manoel Brunnen <mb@lee-brunnen.de>
carlescufi pushed a commit that referenced this pull request May 24, 2023
@mbrunnen @carlescufi
doc: Remove tickless idle from PM in introduction
c51da6f 
Tickless idle has been replaced by the tickless kernel and also power
management has become much more advanced.

See also: #33302

Signed-off-by: Manoel Brunnen <mb@lee-brunnen.de>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request May 26, 2023
@mbrunnen
doc: Remove tickless idle from PM in introduction
961f540 
Tickless idle has been replaced by the tickless kernel and also power
management has become much more advanced.

See also: zephyrproject-rtos/zephyr#33302

(cherry picked from commit c51da6f)

Original-Signed-off-by: Manoel Brunnen <mb@lee-brunnen.de>
GitOrigin-RevId: c51da6f
Change-Id: I4229f319e4930d7f138d6f028e82cc487cd8f5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4566137
Reviewed-by: Keith Short <keithshort@chromium.org>
Tested-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: CopyBot Service Account <copybot.service@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabigot pabigot pabigot left review comments

@albertofloyd albertofloyd albertofloyd approved these changes

@stephanosio stephanosio stephanosio approved these changes

@evgeniy-paltsev evgeniy-paltsev evgeniy-paltsev approved these changes

@andyross andyross andyross approved these changes

@erwango erwango erwango approved these changes

@scottwcpg scottwcpg scottwcpg approved these changes

@jhedberg jhedberg jhedberg approved these changes

@abrodkin abrodkin abrodkin approved these changes

@ceolin ceolin ceolin approved these changes

@carlocaione carlocaione carlocaione approved these changes

@martinjaeger martinjaeger martinjaeger approved these changes

@dcpleung dcpleung dcpleung approved these changes

@joerchan joerchan joerchan approved these changes

@jukkar jukkar jukkar approved these changes

@ruuddw ruuddw ruuddw approved these changes

@vanti vanti Awaiting requested review from vanti

@pfalcon pfalcon Awaiting requested review from pfalcon

@aasthagr aasthagr Awaiting requested review from aasthagr

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@IRISZZW IRISZZW Awaiting requested review from IRISZZW

@jenmwms jenmwms Awaiting requested review from jenmwms

@KangJianX KangJianX Awaiting requested review from KangJianX

@katsuster katsuster Awaiting requested review from katsuster

@mengxianglinx mengxianglinx Awaiting requested review from mengxianglinx

@mgielda mgielda Awaiting requested review from mgielda

@npitre npitre Awaiting requested review from npitre

@Thalley Thalley Awaiting requested review from Thalley

Assignees

@andyross andyross

Labels
area: API Changes to public APIs area: ARC ARC Architecture area: ARM ARM (32-bit) Architecture area: ARM64 ARM (64-bit) Architecture area: Base OS Base OS Library (lib/os) area: Bluetooth area: Boards area: Disk Access area: Documentation area: Ethernet area: Kernel area: native port Host native arch port (native_sim) area: Networking area: NIOS2 NIOS2 Architecture area: Portability Standard compliant code, toolchain abstraction area: Power Management area: RISCV RISCV Architecture (32-bit & 64-bit) area: Shell Shell subsystem area: Sockets Networking sockets area: SPARC SPARC Architecture area: Timer Timer area: X86 x86 Architecture (32-bit) area: Xtensa Xtensa Architecture manifest manifest-hal_ti platform: Microchip MEC Microchip MEC Platform platform: NXP NXP platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.