cmake: move the BOARD variable watch below deprecated board handling #33436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: zephyrproject-rtos#33138 Board alias and deprecated board handling is setting the BOARD variable after zephyr_boilerplate_watch(BOARD) has been executed. This results in the board changed warning. This commit moves the zephyr_boilerplate_watch(BOARD) code below the board alias and deprecation handling. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
tejlmand
added
bug
mbolivar-nordic
approved these changes
Mar 17, 2021
galak
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33138
Board alias and deprecated board handling is setting the BOARD variable
after
zephyr_boilerplate_watch(BOARD)has been executed.This results in the board changed warning.
This commit moves the
zephyr_boilerplate_watch(BOARD)code below theboard alias and deprecation handling.
Signed-off-by: Torsten Rasmussen Torsten.Rasmussen@nordicsemi.no