Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcc: fix k_poll event initializer and remove intel_s1000 log/ztest fixups #33689

Merged
merged 2 commits into from
Mar 26, 2021
Merged

xcc: fix k_poll event initializer and remove intel_s1000 log/ztest fixups #33689

merged 2 commits into from
Mar 26, 2021

Conversation

dcpleung
Copy link
Member

  • This adds brackets to the union element in the k_poll event initializer.
  • Remove the log/ztest fixups for intel_s1000 as they are no longer needed.

dcpleung added 2 commits March 24, 2021 13:24
@dcpleung
soc: intel_s1000: remove log and ztest XCC fixes
e11bf55 
These fixes are no longer needed for apps to compile.
So removing them.

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@dcpleung
kernel: fix XCC compilation with k_poll event initializer
7348cb5 
XCC (which is based on GCC 4.2) needs the initializer of
one of the union elements to be enclosed in brackets.
So add them.

Fixes zephyrproject-rtos#33549

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
@github-actions github-actions bot added the area: API Changes to public APIs label Mar 24, 2021
@dcpleung dcpleung linked an issue Mar 24, 2021 that may be closed by this pull request
xt-xcc unknown field 'obj' specified in initializer #33549
Closed
@zephyrbot zephyrbot requested a review from ceolin March 25, 2021 12:20
@nashif nashif requested review from lyakh and lgirdwood March 26, 2021 12:42
@galak galak merged commit 087fb94 into zephyrproject-rtos:master Mar 26, 2021
@dcpleung dcpleung deleted the xcc_fix_again branch March 26, 2021 16:38
@MaureenHelm MaureenHelm mentioned this pull request Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galak galak galak approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@nashif nashif nashif approved these changes

@andyross andyross Awaiting requested review from andyross

@ceolin ceolin Awaiting requested review from ceolin

@lyakh lyakh Awaiting requested review from lyakh

Assignees

@nashif nashif

Labels
area: API Changes to public APIs area: Kernel platform: Intel ADSP Intel Audio platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xt-xcc unknown field 'obj' specified in initializer
5 participants
@dcpleung @nashif @lgirdwood @galak @zephyrbot