Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel: Improve single thread (CONFIG_MULTITHREADING=n) support #34279

Merged
merged 22 commits into from
Apr 29, 2021
Merged

Kernel: Improve single thread (CONFIG_MULTITHREADING=n) support #34279

merged 22 commits into from
Apr 29, 2021

Conversation

nordic-krch
Copy link
Contributor

An attempt to improve no multithreading (no-mt) support in order to keep it in the tree by:

  • cleanup in kernel/timer as k_timer is expected to work in no-mt
  • extending tests/kernel/timer/timer_api to validate no-mt case
  • cleanup in kernel so that number of kernel source files can be limited when no-mt.
  • added support for no-mt in ztest
  • added sanity test for no-mt which validates that expected features are working: k_busy_wait, k_timer, irq_locking, k_cpu_idle, SYS_INIT
  • removing z_arm_pendsv from vector table
  • reverted deprecation of no-mt.

Note that currently all existing multithreading tests are passing only on cortex_m but having test coverage for expected scope will help to add support for other platforms.

Separate PR will cover documentation (will be based on #29338).

@github-actions github-actions bot added area: ARM ARM (32-bit) Architecture area: Kernel area: Test Framework Issues related not to a particular test, but to the framework instead area: Tests Issues related to a particular existing or missing test labels Apr 14, 2021
@nordic-krch nordic-krch mentioned this pull request Apr 14, 2021
Closed
4 tasks
@nordic-krch nordic-krch requested review from carlescufi, andyross and nashif and removed request for carlescufi April 15, 2021 08:07
@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch from b6797e8 to f4748cb Compare April 15, 2021 08:49
@carlescufi carlescufi requested a review from npitre April 15, 2021 10:58
@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch from 8301cee to 56328ad Compare April 15, 2021 11:04
@carlescufi carlescufi requested a review from katsuster April 15, 2021 12:37
andyross
andyross approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it fits much with Zephyr's overall market direction (increasingly moving into larger and more complicated systems), but it's nice to see this being resurrected. Any data on binary size to share?

@carlescufi
Copy link
Member

Not that it fits much with Zephyr's overall market direction (increasingly moving into larger and more complicated systems), but it's nice to see this being resurrected. Any data on binary size to share?

Thank you @andyross. I do not want to reopen the discussion about the usefulness of the feature but suffice to say that the fact that we are investing time and effort into it, that we commit to maintaining it, that the ARC architecture might use it in the future and that it was useful for the Aarch64 maintainers when initially bringing up the platform should be enough reason to keep it.

@npitre
Copy link
Collaborator

npitre commented Apr 15, 2021 via email

@hongshui3000
Copy link
Contributor

hongshui3000 commented Apr 16, 2021 •
edited
Loading

This is good news. I can still use single-threaded + my own single-threaded thing-driven framework to develop simple applications. At the same time, I can also use the zephyr software ecosystem.
If someone can separate the related content in the mayfly directory(zephyr/subsys/bluetooth/controller/util/) from the Bluetooth controller code and provide it for single-threaded tasks, I think it would be more perfect.
This will also enable the single-threaded mode to have greater vitality in the future to survive under this complex zephyr system

@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch from 56328ad to 17b67ab Compare April 16, 2021 10:35
@nordic-krch
Copy link
Contributor Author

@andyross regarding:

Any data on binary size to share?

Savings are not stunning (~2k) but it depends on the perspective. If you want to fit your bootloader in 4k pages. Then such savings may mean 4k vs 8k and that becomes significant.

@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch from 17b67ab to 50e1958 Compare April 19, 2021 09:40
@nordic-krch nordic-krch mentioned this pull request Apr 19, 2021
Merged
@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch 3 times, most recently from 56ce748 to 0d24343 Compare April 20, 2021 05:26
nordic-krch and others added 14 commits April 29, 2021 08:17
@nordic-krch
tests: kernel: timer: timer_api: Extend with CONFIG_MULTITHREADING=n …
349b356 
…case

Extended test to validate that timer API is working as expected
when CONFIG_MULTITHREADING=n.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
tests: kernel: threads: no-multithreading: Extend test
bbd1f21 
Extended test to validate following functionality:
- k_busy_wait
- k_timer
- irq_lock/irq_unlock
- k_cpu_idle
- SYS_INIT()

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
tests: kernel: mem_slab: Add no multithreading support
7c238a7 
Extended mslab_api test suite with CONFIG_MULTITHREADING=n
configuration.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
tests: kernel: mem_heap: Add CONFIG_MULTITHREADING=n configuration
392b1ac 
Extended mheap_api_concept test suite to support case when
multithreading is disabled.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
Revert "kernel: Deprecate CONFIG_MULTITHREADING"
c3ffc27 
This reverts commit 28cb9da.
@pabigot @nordic-krch
doc: kernel: document general policy for Zephyr without threads
125f988 
This provides the documentation of scope required as a stage towards
removing deprecation for CONFIG_MULTITHREADING=n.  The specific lists
of what does work will follow as the code base is inspected and
updated.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
debug: Allow spin lock validation only with multithreading
e521a75 
Spin lock validation is touching threads. Allow only when
multithreading is enabled.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
drivers: clock_control: nrf: Supoprt no multithreading
fa1be85 
Add support to no multithreading configuration.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
drivers: serial: nrf_uarte: Support for no multithreading
beb9073 
Don use k_sleep when multithreading is disabled.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
logging: Fix support for no multithreading
547ae66 
Fixed to ensure that semaphore is not used by the log core
when multithreading is disabled.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
soc: arm: nordic: Do not use PM when no multithreading
8f72731 
Enable by default power managment only when multithreading is
enabled.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
tests: kernel: fatal: Add no multithreading test
1726756 
Added test which verifies that when multithreading is disabled
exception as correctly handled by the kernel.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
boards: arm: qemu_cortex_m0: use LFXTAL
f2ed72e 
Update configuration of qemu_cortex_m0 to use LF XTAL as low
frequency clock source. Previously used RC requires more
modules to be fetched into the build, including TEMP sensor
used for clock calibration.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch
irq_offload: Remove ifdef from the api
0519100 
Removed #ifdef that guarded irq_offload API.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
@nordic-krch nordic-krch force-pushed the kernel/no_multithreading branch from 537b679 to 0519100 Compare April 29, 2021 06:19
@nordic-krch
Copy link
Contributor Author

@carlescufi rebased, CI green except for compliance failure that we need to live with.

@carlescufi carlescufi merged commit a1829cf into zephyrproject-rtos:master Apr 29, 2021
@nordic-krch nordic-krch mentioned this pull request Apr 30, 2021
Closed
@ioannisg ioannisg mentioned this pull request May 3, 2021
Merged
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 11, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
2dc5a98 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() by itself for entering idle mode, which
allows for reduction power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 14, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
87dc249 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE_WFE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 14, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
461ef63 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE_WFE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 14, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
867dcfe 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE_WFE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 14, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
bb7928d 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE_WFE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/mcuboot that referenced this pull request Jun 16, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
3c19e0f 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to mcu-tools/mcuboot that referenced this pull request Jun 17, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
aea38eb 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
sigvartmh pushed a commit to sigvartmh/fw-nrfconnect-mcuboot-1 that referenced this pull request Aug 3, 2021
@nvlsianpu @sigvartmh
boot/boot_serial: call idle for reducing power in single thread
ea0fe9c 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
sigvartmh pushed a commit to sigvartmh/fw-nrfconnect-mcuboot-1 that referenced this pull request Aug 9, 2021
@nvlsianpu @sigvartmh
boot/boot_serial: call idle for reducing power in single thread
853a4d2 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu added a commit to nvlsianpu/fw-nrfconnect-mcuboot that referenced this pull request Dec 2, 2021
@nvlsianpu
boot/boot_serial: call idle for reducing power in single thread
31e7015 
Sine zephyr zephyrproject-rtos/zephyr#34279
was merged there is no silent idle thread created automatically while
CONFIG_MULTITHREADING=n. Since that any single thread application
needs to call k_cpu_idle() (wrapped by MCUBOOT_CPU_IDLE)
by itself for entering idle mode, which allows for reduction
power consumption.

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
@nandojve nandojve mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcpleung dcpleung dcpleung approved these changes

@carlescufi carlescufi carlescufi approved these changes

@npitre npitre npitre approved these changes

@andyross andyross andyross approved these changes

@nashif nashif Awaiting requested review from nashif

@katsuster katsuster Awaiting requested review from katsuster

@anangl anangl Awaiting requested review from anangl

@ioannisg ioannisg Awaiting requested review from ioannisg

@Mierunski Mierunski Awaiting requested review from Mierunski

Assignees
No one assigned
Labels
area: API Changes to public APIs area: ARM ARM (32-bit) Architecture area: Boards area: Documentation area: Kernel area: Logging area: Test Framework Issues related not to a particular test, but to the framework instead area: Tests Issues related to a particular existing or missing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nordic-krch @carlescufi @npitre @hongshui3000 @andyross @dcpleung @pabigot