twister: Fix ram/rom reporting #34287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The info of rom/ram usage by an application was lost along the way of data processing in twister. The commit add a line which pass further these metrices as well. Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
|
The difference can be seen in the generated json report while calling with and without the above commit |
|
I still see that the data is missing in the report when using --build-only. Will debug further |
With the previous logic memory footprint can only be saved in a report if a given test/sample was fully executed and passed (built and run), hence build-only tests were not providing these metrics. This commit modifies the logic so that it is enough to have the build successful to be able to get the memory footprint. Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
|
The second commit fixes memory footprint reporting for build-only tests. |
enjiamai
approved these changes
Apr 16, 2021
nashif
approved these changes
Apr 19, 2021
hakehuang
reviewed
Apr 19, 2021
| @@ -1215,6 +1215,7 @@ def main(): | |||
| except queue.Empty: | |||
| break | |||
| else: | |||
| inst.metrics.update(suite.instances[inst.name].metrics) | |||
There was a problem hiding this comment.
maybe below code would be more safe.
ram_size = suite.instance.metrics.get("ram_size", 0)
rom_size = suite.instance.metrics.get("rom_size", 0)
inst.metrics["ram_size"] = ram_size
inst.metrics["rom_size"] = rom_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The info of rom/ram usage by an application was lost along the
way of data processing in twister. The PR add a line which
pass further these metrices as well.
In addition a logic for memory footprint reporting is fixed.
With the previous logic memory footprint can only be saved in a report
if a given test/sample was fully executed and passed (built and run),
hence build-only tests were not providing these metrics. This PR
modifies the logic so that it is enough to have the build successful
to be able to get the memory footprint.
Fixes #34272
Signed-off-by: Maciej Perkowski Maciej.Perkowski@nordicsemi.no