arch: arm: aarch32: Fix spurious interrupt handling #34396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GIC can return 0x3ff to indicate a spurious interrupt. Other interrupt controllers could return something different. Check that the pending interrupt is valid in order to avoid indexing past the end of the isr_table. This fixes zephyrproject-rtos#30465 and is based on the aarch64 fix in 9dd2731. Signed-off-by: Bradley Bolen <bbolen@lexmark.com>
carlocaione
approved these changes
Apr 19, 2021
ioannisg
approved these changes
Apr 20, 2021
| @@ -183,6 +183,14 @@ _idle_state_cleared: | |||
| * interface function. | |||
| */ | |||
| cpsie i | |||
|
|
|||
| /* | |||
| * Skip calling the isr if it is a spurious interrupt. | |||
There was a problem hiding this comment.
Perhaps this comment is misleading, we don't really check for spurious interrupt, we just make sure we are not going out of bound which has the side effect of covering spurious interrupts from GIC.
julien-massot
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIC can return 0x3ff to indicate a spurious interrupt. Other
interrupt controllers could return something different. Check that the
pending interrupt is valid in order to avoid indexing past the end of
the isr_table.
This fixes #30465 and is based on the aarch64 fix in 9dd2731.
Signed-off-by: Bradley Bolen bbolen@lexmark.com