-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: DTS post-processing of ELF file depends on CONFIG_HAS_DTS #34449
cmake: DTS post-processing of ELF file depends on CONFIG_HAS_DTS #34449
Conversation
Only run gen_handles.py if CONFIG_HAS_DTS is set. This enables vendors without device tree implementations to compile without the generated dependencies. Signed-off-by: Morten Priess <mtpr@oticon.com>
Closed/reopened to rerun CI |
Can anybody help with the CI errors? Is it because some configurations are using DTS, but somehow set CONFIG_HAS_DTS=n? |
@pabigot can you assist ? |
In I suspect platforms that don't have devicetree aren't going to make it very far in the Zephyr of the future. @galak @mbolivar-nordic FYI in case this is something to consider from an architectural level. |
Thanks! I will add a commit with that selected. |
I can understand that from a Zephyr architectural perspective. I will inform my colleagues of the deprecation, and hopefully we can go the DTS-way in the next generation. |
With PR#34449, architectures that use DTS must select the HAS_DTS configuration. Signed-off-by: Morten Priess <mtpr@oticon.com>
That is my general impression as well, as documented in https://docs.zephyrproject.org/latest/guides/dts/design.html#single-source-for-all-hardware-information though this is ongoing work. Basic things like "be able to create a struct device that isn't from devicetree" will continue to work "forever", though, as far as I know. I never use platforms without DTS though, not sure if we've got project level decisions made on the future of |
@pabigot, so is this acceptable for the time being? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabigot, so is this acceptable for the time being?
I don't like it, because it seems clear DTS is not an optional part of Zephyr, but until that's written into policy this seems the only way to make progress. Presumably some day somebody will get rid of CONFIG_HAS_DTS
entirely and the hack will be removed at that point.
Only run gen_handles.py if CONFIG_HAS_DTS is set. This enables vendors
without device tree implementations to compile without the generated
dependencies.
Fixes #34416.
Signed-off-by: Morten Priess mtpr@oticon.com