Logging: Fix issues that leads to failures when compiling for C++ #34516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
requested review from
carlescufi,
galak,
MaureenHelm and
nashif
as code owners
carlescufi
approved these changes
Apr 23, 2021
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 23, 2021
Cleanup to fix warnings coming from c++ compilation. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit f78fc3fe3b0356ab1fe3da4f9e56ef5642994838) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 23, 2021
Add guard to not use C11 specific feature when in C++. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit a51eac6c073ae943fe45fd0a8b363ba1957d7347) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 23, 2021
Fixed C++ warnings coming from implicit casting. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit b10bf7299d2414cc48814e4eb6cd70477057bb3f) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
dcpleung
approved these changes
Apr 23, 2021
nordic-krch
force-pushed
the
logging2_cpp
branch
2 times, most recently
from
0f2b496 to
0d6f038
Compare
|
@nordic-krch please rebase |
|
@nordic-krch would be good to have some test extended to check this out on C++. |
Cleanup to fix warnings coming from c++ compilation. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Add guard to not use C11 specific feature when in C++. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Fixed C++ warnings coming from implicit casting. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
logging2_cpp
branch
from
0d6f038 to
64e33af
Compare
|
@galak I'm working on that. |
|
Tested on ARC MWDT (LLVM based) toolchain. Everything is OK. |
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 27, 2021
Cleanup to fix warnings coming from c++ compilation. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit d8076c3527331bb8887edda3f1386b1227867027) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 27, 2021
Add guard to not use C11 specific feature when in C++. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit eadf2fe8f4906d30400f6f8178c4593cac34852d) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
pushed a commit
to trond-snekvik/sdk-zephyr
that referenced
this pull request
Apr 27, 2021
Fixed C++ warnings coming from implicit casting. Upstream PR: zephyrproject-rtos/zephyr#34516 Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit 0d6f038d77105695c006728f5dcf40229247464c) Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving few casting issues in logging headers.
Limiting
_Genericusage in cbprintf to C only.I will work towards extending logging tests to validate C++ case.
Note, that for now logging v2 will work slower for C++ because
_Genericcannot be used. This will also be fixed.Fixes #34495.
Fixes #34527.